| Message ID | 20220819054255.2406633-1-klee33@uw.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ceph: Use kcalloc for allocating multiple elements | expand |
On 8/19/22 1:42 PM, Kenneth Lee wrote: > Prefer using kcalloc(a, b) over kzalloc(a * b) as this improves > semantics since kcalloc is intended for allocating an array of memory. > > Signed-off-by: Kenneth Lee <klee33@uw.edu> > --- > fs/ceph/caps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c > index 53cfe026b3ea..1eb2ff0f6bd8 100644 > --- a/fs/ceph/caps.c > +++ b/fs/ceph/caps.c > @@ -2285,7 +2285,7 @@ static int flush_mdlog_and_wait_inode_unsafe_requests(struct inode *inode) > struct ceph_mds_request *req; > int i; > > - sessions = kzalloc(max_sessions * sizeof(s), GFP_KERNEL); > + sessions = kcalloc(max_sessions, sizeof(s), GFP_KERNEL); > if (!sessions) { > err = -ENOMEM; > goto out; Merged into the testing branch. Thanks Kenneth! -- Xiubo
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 53cfe026b3ea..1eb2ff0f6bd8 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -2285,7 +2285,7 @@ static int flush_mdlog_and_wait_inode_unsafe_requests(struct inode *inode) struct ceph_mds_request *req; int i; - sessions = kzalloc(max_sessions * sizeof(s), GFP_KERNEL); + sessions = kcalloc(max_sessions, sizeof(s), GFP_KERNEL); if (!sessions) { err = -ENOMEM; goto out;
Prefer using kcalloc(a, b) over kzalloc(a * b) as this improves semantics since kcalloc is intended for allocating an array of memory. Signed-off-by: Kenneth Lee <klee33@uw.edu> --- fs/ceph/caps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)