diff mbox series

ceph/004: fix the ceph.quota.max_bytes values

Message ID 20220829070921.547074-1-xiubli@redhat.com (mailing list archive)
State New, archived
Headers show
Series ceph/004: fix the ceph.quota.max_bytes values | expand

Commit Message

Xiubo Li Aug. 29, 2022, 7:09 a.m. UTC 
From: Xiubo Li <xiubli@redhat.com>

Cephfs has required that the quota.max_bytes must be aligned to
4MB if greater than or equal to 4MB, otherwise must align to 4KB.

URL: https://tracker.ceph.com/issues/57321
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
 tests/ceph/004 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Luis Henriques Aug. 29, 2022, 1:32 p.m. UTC | #1 
On Mon, Aug 29, 2022 at 03:09:21PM +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> Cephfs has required that the quota.max_bytes must be aligned to
> 4MB if greater than or equal to 4MB, otherwise must align to 4KB.

Although the MDS change that will force this hasn't yet been merged, this
test change looks reasonable anyway.  Feel free to add my:

Reviewed-by: Luís Henriques <lhenriques@suse.de>

Cheers,
--
Luís

> 
> URL: https://tracker.ceph.com/issues/57321
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  tests/ceph/004 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/ceph/004 b/tests/ceph/004
> index dbca713e..124ed1bc 100755
> --- a/tests/ceph/004
> +++ b/tests/ceph/004
> @@ -9,7 +9,7 @@
>  #
>  #    mkdir files limit
>  #    truncate files/file -s 10G
> -#    setfattr limit -n ceph.quota.max_bytes -v 1000000
> +#    setfattr limit -n ceph.quota.max_bytes -v 1048576
>  #    mv files limit/
>  #
>  # Because we're creating a new file and truncating it, we have Fx caps and thus
> @@ -76,9 +76,9 @@ check_Fs_caps()
>  }
>  
>  # set quota to 1m
> -$SETFATTR_PROG -n ceph.quota.max_bytes -v 1000000 $dest
> +$SETFATTR_PROG -n ceph.quota.max_bytes -v 1048576 $dest
>  # set quota to 20g
> -$SETFATTR_PROG -n ceph.quota.max_bytes -v 20000000000 $orig2
> +$SETFATTR_PROG -n ceph.quota.max_bytes -v 21474836480 $orig2
>  
>  #
>  # The following 2 testcases shall fail with either -EXDEV or -EDQUOT
> -- 
> 2.36.0.rc1
>
diff mbox series

Patch

diff --git a/tests/ceph/004 b/tests/ceph/004
index dbca713e..124ed1bc 100755
--- a/tests/ceph/004
+++ b/tests/ceph/004
@@ -9,7 +9,7 @@ 
 #
 #    mkdir files limit
 #    truncate files/file -s 10G
-#    setfattr limit -n ceph.quota.max_bytes -v 1000000
+#    setfattr limit -n ceph.quota.max_bytes -v 1048576
 #    mv files limit/
 #
 # Because we're creating a new file and truncating it, we have Fx caps and thus
@@ -76,9 +76,9 @@  check_Fs_caps()
 }
 
 # set quota to 1m
-$SETFATTR_PROG -n ceph.quota.max_bytes -v 1000000 $dest
+$SETFATTR_PROG -n ceph.quota.max_bytes -v 1048576 $dest
 # set quota to 20g
-$SETFATTR_PROG -n ceph.quota.max_bytes -v 20000000000 $orig2
+$SETFATTR_PROG -n ceph.quota.max_bytes -v 21474836480 $orig2
 
 #
 # The following 2 testcases shall fail with either -EXDEV or -EDQUOT