diff mbox series

ceph: Remove empty definition in header file

Message ID 20240906060134.129970-1-zhangzekun11@huawei.com (mailing list archive)
State New
Headers show
Series ceph: Remove empty definition in header file | expand

Commit Message

Zhang Zekun Sept. 6, 2024, 6:01 a.m. UTC
The real definition of ceph_acl_chmod() has been removed since
commit 4db658ea0ca2 ("ceph: Fix up after semantic merge conflict"),
remain the empty definition untouched in the header files. Let's
remove the empty definition.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
 fs/ceph/super.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Xiubo Li Sept. 6, 2024, 10:56 a.m. UTC | #1
On 9/6/24 14:01, Zhang Zekun wrote:
> The real definition of ceph_acl_chmod() has been removed since
> commit 4db658ea0ca2 ("ceph: Fix up after semantic merge conflict"),
> remain the empty definition untouched in the header files. Let's
> remove the empty definition.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
>   fs/ceph/super.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index c88bf53f68e9..384eac22db57 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1206,10 +1206,6 @@ static inline void ceph_init_inode_acls(struct inode *inode,
>   					struct ceph_acl_sec_ctx *as_ctx)
>   {
>   }
> -static inline int ceph_acl_chmod(struct dentry *dentry, struct inode *inode)
> -{
> -	return 0;
> -}
>   
>   static inline void ceph_forget_all_cached_acls(struct inode *inode)
>   {

Hi Zekun,

Thanks for your patch and LGTM.

Reviewed-by: Xiubo Li <xiubli@redhat.com
diff mbox series

Patch

diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index c88bf53f68e9..384eac22db57 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -1206,10 +1206,6 @@  static inline void ceph_init_inode_acls(struct inode *inode,
 					struct ceph_acl_sec_ctx *as_ctx)
 {
 }
-static inline int ceph_acl_chmod(struct dentry *dentry, struct inode *inode)
-{
-	return 0;
-}
 
 static inline void ceph_forget_all_cached_acls(struct inode *inode)
 {