| Message ID | 504A63FC.1080005@inktank.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Until layering is implemented, this should report an error if features is not 0. Layering is feature bit 1. You can copy the userspace header from ceph.git in src/include/librbd/features.h to use the same feature macros. On 09/07/2012 02:15 PM, Alex Elder wrote: > Now that v2 images support is fully implemented, have > rbd_dev_v2_probe() return 0 to indicate a successful probe. > > Signed-off-by: Alex Elder <elder@inktank.com> > --- > drivers/block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index b466393..2f83f71 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -2973,7 +2973,7 @@ static int rbd_dev_v2_probe(struct rbd_device > *rbd_dev) > dout("discovered version 2 image, header name is %s\n", > rbd_dev->header_name); > > - return -ENOTSUPP; > + return 0; > out_err: > kfree(rbd_dev->header_name); > rbd_dev->header_name = NULL; > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/19/2012 12:56 PM, Josh Durgin wrote: > Until layering is implemented, this should report an > error if features is not 0. Layering is feature bit 1. > > You can copy the userspace header from ceph.git in > src/include/librbd/features.h to use the same feature macros. err, that's src/include/rbd/features.h > On 09/07/2012 02:15 PM, Alex Elder wrote: >> Now that v2 images support is fully implemented, have >> rbd_dev_v2_probe() return 0 to indicate a successful probe. >> >> Signed-off-by: Alex Elder <elder@inktank.com> >> --- >> drivers/block/rbd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index b466393..2f83f71 100644 >> --- a/drivers/block/rbd.c >> +++ b/drivers/block/rbd.c >> @@ -2973,7 +2973,7 @@ static int rbd_dev_v2_probe(struct rbd_device >> *rbd_dev) >> dout("discovered version 2 image, header name is %s\n", >> rbd_dev->header_name); >> >> - return -ENOTSUPP; >> + return 0; >> out_err: >> kfree(rbd_dev->header_name); >> rbd_dev->header_name = NULL; >> > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index b466393..2f83f71 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2973,7 +2973,7 @@ static int rbd_dev_v2_probe(struct rbd_device *rbd_dev) dout("discovered version 2 image, header name is %s\n", rbd_dev->header_name); - return -ENOTSUPP; + return 0; out_err: kfree(rbd_dev->header_name);
Now that v2 images support is fully implemented, have rbd_dev_v2_probe() return 0 to indicate a successful probe. Signed-off-by: Alex Elder <elder@inktank.com> --- drivers/block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rbd_dev->header_name = NULL;