From patchwork Sun Oct 21 21:31:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Buck X-Patchwork-Id: 1623101 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 11FD4DFFF1 for ; Sun, 21 Oct 2012 21:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754655Ab2JUVb6 (ORCPT ); Sun, 21 Oct 2012 17:31:58 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:43788 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754574Ab2JUVb6 (ORCPT ); Sun, 21 Oct 2012 17:31:58 -0400 Received: by mail-da0-f46.google.com with SMTP id n41so1053716dak.19 for ; Sun, 21 Oct 2012 14:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=3sQxEkYN2gL8ILp3Y5Ci/hUGY/l9qSe1wtA4cYRVB2Y=; b=QhN9vwLJnaKqBj1rj8ATR9BwpuNaJFLWjkcEbTeFkJzrlmQUswm/MxMg1w5xAOLcIJ RSccJQRISpS2VzCjo4Z8lR7wQ9wNB3cbNNzEzz9JGa7bgRqZd6gIMWWpoLr2knFeHHBP olUQzMAVGfWu1hfy7WpdqlPp6wAZiKtnbZ9L001MYri1Gx2pb6ba5CaWuEIJVPfzQ1p4 pHkQisMD5NBO8XARlzDGg3zacKDfWjJn8ZF0YP9sscrd3rDxvLJ+fq7F0Ar+0CPf2i29 FA5JEsQ0XWjXY/BBUjWTi/2SfE7WqMAYBHwy6fPiokBBWulw1eJ8MPv95kU0ghFi3t89 b1Ag== Received: by 10.68.192.97 with SMTP id hf1mr24380952pbc.106.1350855117768; Sun, 21 Oct 2012 14:31:57 -0700 (PDT) Received: from [128.114.52.35] (bender.soe.ucsc.edu. [128.114.52.35]) by mx.google.com with ESMTPS id pf4sm3954234pbc.38.2012.10.21.14.31.56 (version=SSLv3 cipher=OTHER); Sun, 21 Oct 2012 14:31:57 -0700 (PDT) Message-ID: <508469CE.3000502@gmail.com> Date: Sun, 21 Oct 2012 14:31:58 -0700 From: Joe Buck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: "ceph-devel@vger.kernel.org" Subject: Proposed change to vstart.sh Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org It looks like vstart.sh does not work without authx enabled. Given that, I'd propose to change the default to having cephx be enabled and then use the -x flag to disable cephx. Interestingly enough, the help output for vstart.sh already states that the -x flag disables authx (which is not the case at present, but is after this patch is applied). I've attached a patch to vstart that 1) changes the mention of authx to cephx for consistency and 2) defaults vstart.sh to using cephx with the -x flag now serving to disable cephx. Best, -Joe Buck diff --git a/src/vstart.sh b/src/vstart.sh index 7aaad49..b23b83a 100755 --- a/src/vstart.sh +++ b/src/vstart.sh @@ -21,7 +21,7 @@ ip="" nodaemon=0 smallmds=0 overwrite_conf=1 -cephx=0 +cephx=1 #turn cephx on by default MON_ADDR="" @@ -43,7 +43,7 @@ usage=$usage"\t--nodaemon: use ceph-run as wrapper for mon/osd/mds\n" usage=$usage"\t--smallmds: limit mds cache size\n" usage=$usage"\t-m ip:port\t\tspecify monitor address\n" usage=$usage"\t-k keep old configuration files\n" -usage=$usage"\t-x disable authx\n" +usage=$usage"\t-x disable cephx\n" usage=$usage"\t-o config\t\t add extra config parameters to mds section\n" usage_exit() { @@ -117,7 +117,7 @@ case $1 in shift ;; -x ) - cephx=1 + cephx=0 ;; -k ) overwrite_conf=0