Message ID | 50C52EBC.9070701@inktank.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index c018e52..218a97f 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -833,8 +833,8 @@ static void __unregister_linger_request(struct ceph_osd_client *osdc, struct ceph_osd_request *req) { dout("__unregister_linger_request %p\n", req); + list_del_init(&req->r_linger_item); if (req->r_osd) { - list_del_init(&req->r_linger_item); list_del_init(&req->r_linger_osd);
In __unregister_linger_request(), the request is being removed from the osd client's req_linger list only when the request has a non-null osd pointer. It should be done whether or not the request currently has an osd. This is most likely a non-issue because I believe the request will always have an osd when this function is called. Signed-off-by: Alex Elder <elder@inktank.com> --- net/ceph/osd_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) if (list_empty(&req->r_osd->o_requests) &&