diff mbox

litte bug in initscripts

Message ID 50CAD151.5080306@rocknob.de (mailing list archive)
State New, archived
Headers show

Commit Message

norbi Dec. 14, 2012, 7:12 a.m. UTC 
Hi Ceph-List,

i have found a little bug in "ceph_common.sh"
"/usr/local/bin/ceph-conf --help" show the right option to get a 
hostname from the ceph.conf. in my case, the ceph init-script doesnt 
stop/start the OSDs

FLAGS
   --name name                     Set type.id

or the example

EXAMPLES
$ ceph-conf --name mon.0 -c /etc/ceph/ceph.conf 'mon addr'


Patchfile

       return 1

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

norbi Dec. 14, 2012, 7:46 a.m. UTC | #1 
hm...

now the MOD and MON doesn't start...

the problems seems the configuration differences in ceph.conf

http://ceph.com/docs/master/rados/configuration/ceph-conf/#the-ceph-conf-file

or its a failure in the documentation?

[osd.0]
         hostname = {hostname}

[mon.a]
         host = hostName
         mon addr = 150.140.130.120:6789

if i change "host = hostName" to "hostname = hostName" under "[mon.a]" i 
dont have to patch "ceph_common.sh"

On 14.12.2012 08:12, norbi wrote:
> Hi Ceph-List,
>
> i have found a little bug in "ceph_common.sh"
> "/usr/local/bin/ceph-conf --help" show the right option to get a
> hostname from the ceph.conf. in my case, the ceph init-script doesnt
> stop/start the OSDs
>
> FLAGS
>    --name name                     Set type.id
>
> or the example
>
> EXAMPLES
> $ ceph-conf --name mon.0 -c /etc/ceph/ceph.conf 'mon addr'
>
>
> Patchfile
>
> --- src/ceph_common.sh.old      2012-12-14 08:09:09.792952462 +0100
> +++ src/ceph_common.sh.new      2012-12-14 08:09:28.927956891 +0100
> @@ -33,7 +33,7 @@ verify_conf() {
>
>   check_host() {
>       # what host is this daemon assigned to?
> -    host=`$CCONF -c $conf -n $type.$id host`
> +    host=`$CCONF -c $conf --name $type.$id hostname`
>       if [ "$host" = "localhost" ]; then
>        echo "$0: use a proper short hostname (hostname -s), not
> 'localhost', in $conf section $type.$id; skipping entry"
>        return 1
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Josh Durgin Dec. 17, 2012, 4:34 p.m. UTC | #2 
On 12/13/2012 11:46 PM, norbi wrote:
> hm...
>
> now the MOD and MON doesn't start...
>
> the problems seems the configuration differences in ceph.conf
>
> http://ceph.com/docs/master/rados/configuration/ceph-conf/#the-ceph-conf-file
>
>
> or its a failure in the documentation?

It's a type in the docs, which is now fixed.
It should be host = {hostname} for all sections.

Josh

> [osd.0]
>          hostname = {hostname}
>
> [mon.a]
>          host = hostName
>          mon addr = 150.140.130.120:6789
>
> if i change "host = hostName" to "hostname = hostName" under "[mon.a]" i
> dont have to patch "ceph_common.sh"
>
> On 14.12.2012 08:12, norbi wrote:
>> Hi Ceph-List,
>>
>> i have found a little bug in "ceph_common.sh"
>> "/usr/local/bin/ceph-conf --help" show the right option to get a
>> hostname from the ceph.conf. in my case, the ceph init-script doesnt
>> stop/start the OSDs
>>
>> FLAGS
>>    --name name                     Set type.id
>>
>> or the example
>>
>> EXAMPLES
>> $ ceph-conf --name mon.0 -c /etc/ceph/ceph.conf 'mon addr'
>>
>>
>> Patchfile
>>
>> --- src/ceph_common.sh.old      2012-12-14 08:09:09.792952462 +0100
>> +++ src/ceph_common.sh.new      2012-12-14 08:09:28.927956891 +0100
>> @@ -33,7 +33,7 @@ verify_conf() {
>>
>>   check_host() {
>>       # what host is this daemon assigned to?
>> -    host=`$CCONF -c $conf -n $type.$id host`
>> +    host=`$CCONF -c $conf --name $type.$id hostname`
>>       if [ "$host" = "localhost" ]; then
>>        echo "$0: use a proper short hostname (hostname -s), not
>> 'localhost', in $conf section $type.$id; skipping entry"
>>        return 1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- src/ceph_common.sh.old      2012-12-14 08:09:09.792952462 +0100
+++ src/ceph_common.sh.new      2012-12-14 08:09:28.927956891 +0100
@@ -33,7 +33,7 @@  verify_conf() {

  check_host() {
      # what host is this daemon assigned to?
-    host=`$CCONF -c $conf -n $type.$id host`
+    host=`$CCONF -c $conf --name $type.$id hostname`
      if [ "$host" = "localhost" ]; then
       echo "$0: use a proper short hostname (hostname -s), not 
'localhost', in $conf section $type.$id; skipping entry"