From patchwork Fri Dec 14 07:12:17 2012
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: norbi <norbi@rocknob.de>
X-Patchwork-Id: 1877531
Return-Path: <ceph-devel-owner@vger.kernel.org>
X-Original-To: patchwork-ceph-devel@patchwork.kernel.org
Delivered-To: patchwork-process-083081@patchwork1.kernel.org
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by patchwork1.kernel.org (Postfix) with ESMTP id 9B4DA3FC64
	for <patchwork-ceph-devel@patchwork.kernel.org>;
	Fri, 14 Dec 2012 07:12:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751940Ab2LNHMU (ORCPT
	<rfc822;patchwork-ceph-devel@patchwork.kernel.org>);
	Fri, 14 Dec 2012 02:12:20 -0500
Received: from smtprelay02.ispgateway.de ([80.67.31.36]:43068 "EHLO
	smtprelay02.ispgateway.de" rhost-flags-OK-OK-OK-OK) by
	vger.kernel.org with ESMTP id S1751250Ab2LNHMU (ORCPT
	<rfc822; ceph-devel@vger.kernel.org>); Fri, 14 Dec 2012 02:12:20 -0500
Received: from [80.67.16.214] (helo=[192.168.10.165])
	by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.68) (envelope-from <norbi@rocknob.de>) id 1TjPRR-0000Xc-Hl
	for ceph-devel@vger.kernel.org; Fri, 14 Dec 2012 08:12:17 +0100
Message-ID: <50CAD151.5080306@rocknob.de>
Date: Fri, 14 Dec 2012 08:12:17 +0100
From: norbi <norbi@rocknob.de>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: ceph-devel@vger.kernel.org
Subject: litte bug in initscripts
X-Df-Sender: bm9yYmlAcm9ja25vYi5kZQ==
Sender: ceph-devel-owner@vger.kernel.org
Precedence: bulk
List-ID: <ceph-devel.vger.kernel.org>
X-Mailing-List: ceph-devel@vger.kernel.org

Hi Ceph-List,

i have found a little bug in "ceph_common.sh"
"/usr/local/bin/ceph-conf --help" show the right option to get a 
hostname from the ceph.conf. in my case, the ceph init-script doesnt 
stop/start the OSDs

FLAGS
   --name name                     Set type.id

or the example

EXAMPLES
$ ceph-conf --name mon.0 -c /etc/ceph/ceph.conf 'mon addr'


Patchfile

       return 1
---
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- src/ceph_common.sh.old      2012-12-14 08:09:09.792952462 +0100
+++ src/ceph_common.sh.new      2012-12-14 08:09:28.927956891 +0100
@@ -33,7 +33,7 @@ verify_conf() {

  check_host() {
      # what host is this daemon assigned to?
-    host=`$CCONF -c $conf -n $type.$id host`
+    host=`$CCONF -c $conf --name $type.$id hostname`
      if [ "$host" = "localhost" ]; then
       echo "$0: use a proper short hostname (hostname -s), not 
'localhost', in $conf section $type.$id; skipping entry"