From patchwork Sat Feb 16 16:34:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 2151841 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 783683FD4F for ; Sat, 16 Feb 2013 16:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753617Ab3BPQef (ORCPT ); Sat, 16 Feb 2013 11:34:35 -0500 Received: from mail-qa0-f46.google.com ([209.85.216.46]:34676 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753572Ab3BPQee (ORCPT ); Sat, 16 Feb 2013 11:34:34 -0500 Received: by mail-qa0-f46.google.com with SMTP id o13so731310qaj.5 for ; Sat, 16 Feb 2013 08:34:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=Yg8aqMgtRi9DfVxwtzddP7Lv93zTOSis6R1m59Yft3E=; b=nfWAo1T3YgjWZO9LhKjqPYgppxbHSJbW5FXLb/ERp6e5TgVF+1jnlki2fFHpWmu9iH Aij9f5TbfcGj6wptiVxXtHKa0fLNoYIO7rP6PJaHWHYzzI86081ha/isu7MGOp3NQOBX KCQfQPfDGz6ICJ8fffaTFbVLLW2osBMIbfMOIovkdJ47ZiKNpIcc2aGR9o+YrX+xPkzX lYtRq9Ddmmlo97qyTFq1L3Uky4H8oMYsFgYeiC+FH4pFYGLQtzWk4eeKHeLuHqh/UAHM 2Rv0lflkHzF6SBK/v+zjRihw1ucZZgqPjThq4SCo+iFArLTS43arIqhaQ5qbaJkKYP05 U28A== X-Received: by 10.49.127.238 with SMTP id nj14mr2656181qeb.9.1361032473688; Sat, 16 Feb 2013 08:34:33 -0800 (PST) Received: from [172.22.22.4] (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPS id hr3sm21220511qab.4.2013.02.16.08.34.32 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Feb 2013 08:34:32 -0800 (PST) Message-ID: <511FB517.50602@inktank.com> Date: Sat, 16 Feb 2013 10:34:31 -0600 From: Alex Elder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: ceph-devel@vger.kernel.org Subject: [PATCH 2/3] libdeph: don't export ceph_osdc_init() or ceph_osdc_stop() References: <511FB4D9.7050009@inktank.com> In-Reply-To: <511FB4D9.7050009@inktank.com> X-Gm-Message-State: ALoCoQl5Ypva04+IqN85HCKCbJGSuZAwjEIIggU/0ag7dx/QXpLPvoTf64F1ZxVRHZaYAKgQh6QY Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org The only callers of ceph_osdc_init() and ceph_osdc_stop() ceph_create_client() and ceph_destroy_client() (respectively) and they are in the same kernel module as those two functions. There's therefore no need to export those interfaces, so don't. Signed-off-by: Alex Elder --- net/ceph/osd_client.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index edda070..0d67cd3 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -1799,7 +1799,6 @@ out_mempool: out: return err; } -EXPORT_SYMBOL(ceph_osdc_init); void ceph_osdc_stop(struct ceph_osd_client *osdc) { @@ -1816,7 +1815,6 @@ void ceph_osdc_stop(struct ceph_osd_client *osdc) ceph_msgpool_destroy(&osdc->msgpool_op); ceph_msgpool_destroy(&osdc->msgpool_op_reply); } -EXPORT_SYMBOL(ceph_osdc_stop); /* * Read some contiguous pages. If we cross a stripe boundary, shorten