From patchwork Sun Apr 21 21:14:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 2469471 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 46AE7DF230 for ; Sun, 21 Apr 2013 21:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853Ab3DUVOx (ORCPT ); Sun, 21 Apr 2013 17:14:53 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:44499 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720Ab3DUVOw (ORCPT ); Sun, 21 Apr 2013 17:14:52 -0400 Received: by mail-ie0-f181.google.com with SMTP id tp5so3920454ieb.26 for ; Sun, 21 Apr 2013 14:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=y4HNGfWZf8CHCMhbq84s31SPYKOBPcpNg/rtZ2r+w0k=; b=D9VE1nUV9hgK24gYQN+BjNTGxHCUYvjLCBjzdRUIKpQWO2XA29tWjuqI3re+48lZxG w7cYICOYtf+88/yFoxTlbPTNl2c3pNLBC/SlDIPtwcZL2hnItePxcbuFjkVyIHjedOTQ hGJ4iWr5Sb0JhK43NibcqAs4DzGLMKjyy3QbtkryLK0YO3vF1YQG1hWHr1HWfZ0pO7Sb s8UTm4itjamaian4a2FlxwCns76DzdC1scQWi/dNcO6apRFv/MgTl6ZHvbD1wkwljA5G WTs58vcdKACGMk8W4B6bDGUUigeS+QhDCFJFHwJzPTnusG5J29Dclp5yYmdluyIistZR ko/g== X-Received: by 10.50.49.66 with SMTP id s2mr19568606ign.13.1366578892344; Sun, 21 Apr 2013 14:14:52 -0700 (PDT) Received: from [172.22.22.4] (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id wn10sm12917527igb.2.2013.04.21.14.14.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 21 Apr 2013 14:14:51 -0700 (PDT) Message-ID: <517456CA.7040408@inktank.com> Date: Sun, 21 Apr 2013 16:14:50 -0500 From: Alex Elder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: ceph-devel@vger.kernel.org Subject: Re: [PATCH 1/2] libceph: add signed type limits References: <51745629.7080207@inktank.com> <51745656.60504@inktank.com> In-Reply-To: <51745656.60504@inktank.com> X-Gm-Message-State: ALoCoQnUyOaKbKc2SfXv9svk/NBw7iYoQJ57trZCaEnOHNO9qwsS4iGq3w57MaASruqpsMkt/LPd Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org (Sorry, the subject line didn't match the content. Please ignore the previous one--this is the right patch.) Flesh out the limits defined in to include the maximum and minimum values for signed type S8, S16, S32, and S64. Signed-off-by: Alex Elder Reviewed-by: Josh Durgin --- include/linux/ceph/decode.h | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/include/linux/ceph/decode.h b/include/linux/ceph/decode.h index 689f1df..9575a52 100644 --- a/include/linux/ceph/decode.h +++ b/include/linux/ceph/decode.h @@ -10,10 +10,20 @@ /* This seemed to be the easiest place to define these */ -#define U8_MAX ((u8) (~0U)) -#define U16_MAX ((u16) (~0U)) -#define U32_MAX ((u32) (~0U)) -#define U64_MAX ((u64) (~0ULL)) +#define U8_MAX ((u8)(~0U)) +#define U16_MAX ((u16)(~0U)) +#define U32_MAX ((u32)(~0U)) +#define U64_MAX ((u64)(~0ULL)) + +#define S8_MAX ((s8)(U8_MAX >> 1)) +#define S16_MAX ((s16)(U16_MAX >> 1)) +#define S32_MAX ((s32)(U32_MAX >> 1)) +#define S64_MAX ((s64)(U64_MAX >> 1LL)) + +#define S8_MIN ((s8)(-S8_MAX - 1)) +#define S16_MIN ((s16)(-S16_MAX - 1)) +#define S32_MIN ((s32)(-S32_MAX - 1)) +#define S64_MIN ((s64)(-S64_MAX - 1LL)) /* * in all cases,