From patchwork Mon Jun 17 14:19:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: majianpeng X-Patchwork-Id: 2733561 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3EA00C0AB1 for ; Mon, 17 Jun 2013 14:20:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 26B1A20366 for ; Mon, 17 Jun 2013 14:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AA9220363 for ; Mon, 17 Jun 2013 14:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082Ab3FQOT6 (ORCPT ); Mon, 17 Jun 2013 10:19:58 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:41887 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140Ab3FQOT6 (ORCPT ); Mon, 17 Jun 2013 10:19:58 -0400 Received: by mail-pd0-f172.google.com with SMTP id z10so2841651pdj.3 for ; Mon, 17 Jun 2013 07:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=vvgYUytXb3n4rKFLv6uX5h69J3deRnpdMFsg70zEInc=; b=rQwuLfs7zAGRjgO5yQ+8pVotr06VIZM4VmTtSlErxOMLldN5dQJ+oTY5GWC7Byrr4s kau4A5ki3YCgLHJRK9uRAxc2Pyjk9PMN0Ye7djkaVQBxZSRzwP9xaylVvyVMq2sS7C80 SojBHvAbnZj+AcCYKj+97CMeSCwWpqrxPYGsyWTz0eTHUdC/6NRDeLvJKNdcefKG3Anf aD+jSSf7t/fBByV2QSsLfDIxWJO3wtu4ZbEe3hR9vzS5K4HXY7kmuqbiIS7WS0h/uGAS bhKr41Tikshy2K2Ui2z68NZjNA+7PGJRmspTHArM5scsDtAPKmMfIZj1jPbbXdi1uOke BVig== X-Received: by 10.66.144.136 with SMTP id sm8mr13007018pab.115.1371478797709; Mon, 17 Jun 2013 07:19:57 -0700 (PDT) Received: from [192.168.0.101] ([112.65.211.120]) by mx.google.com with ESMTPSA id pm7sm14020176pbb.31.2013.06.17.07.19.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 07:19:56 -0700 (PDT) Message-ID: <51BF1AE7.8040300@gmail.com> Date: Mon, 17 Jun 2013 22:19:19 +0800 From: majianpeng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: sage@inktank.com CC: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ceph: remove sb_start/end_write in ceph_aio_write. Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Either in vfs_write or io_submit,it call file_start/end_write. The different between file_start/end_write and sb_start/end_write is file_ only handle regular file.But i think in ceph_aio_write,it only for regular file. Signed-off-by: Jianpeng Ma Acked-by: Yan, Zheng --- fs/ceph/file.c | 2 -- 1 file changed, 2 deletions(-) -- 1.8.3.rc1.44.gb387c77 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 656e169..7c69f4f 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -716,7 +716,6 @@ static ssize_t ceph_aio_write(struct kiocb *iocb, const struct iovec *iov, if (ceph_snap(inode) != CEPH_NOSNAP) return -EROFS; - sb_start_write(inode->i_sb); mutex_lock(&inode->i_mutex); hold_mutex = true; @@ -809,7 +808,6 @@ retry_snap: out: if (hold_mutex) mutex_unlock(&inode->i_mutex); - sb_end_write(inode->i_sb); current->backing_dev_info = NULL; return written ? written : err;