From patchwork Mon Jun 14 17:37:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yehuda Sadeh Weinraub X-Patchwork-Id: 105991 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o5EHcBW4022839 for ; Mon, 14 Jun 2010 17:38:11 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756403Ab0FNRh4 (ORCPT ); Mon, 14 Jun 2010 13:37:56 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:52125 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756351Ab0FNRhy convert rfc822-to-8bit (ORCPT ); Mon, 14 Jun 2010 13:37:54 -0400 Received: by vws13 with SMTP id 13so32408vws.19 for ; Mon, 14 Jun 2010 10:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=eeVTz440b/lIfvUBy8PWTb5vsZcUsflnZXK/f5JmvVA=; b=bX9w8VfaAiITUv29NFPNJI1bDdB29oLgHXUcwiU+RMFIXnX+rf3wtSWtDTWQCKIjvC Ov0VCFkkOkUWHaKfClNGGqKi+I+xJA2nIVCGt42oFXSqLjZHoP8e4WabDThUfdhm+pQ9 e2NNxvi3auPi2YrqoZ3LSr7wIcV5BjZjMMy+w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=MnEKj3lATQOqWmnFdjrEKtrtJ9mFJRMOptTSe2f5HiS01DQFjYgNpC9TQoNKtyXr5x jph0ZBfCO+weMG8sOPMHzSfBcnQwAGFkB6HpmQiicbebLz29mKoghqIcRuDQoRsmyZOS aCmD4iwenTqBG1y2iFWdUcymU8/QxNcqjH1bA= MIME-Version: 1.0 Received: by 10.220.62.68 with SMTP id w4mr3012933vch.112.1276537073409; Mon, 14 Jun 2010 10:37:53 -0700 (PDT) Received: by 10.220.13.19 with HTTP; Mon, 14 Jun 2010 10:37:53 -0700 (PDT) In-Reply-To: <4C163A7E.6060701@mcs.anl.gov> References: <4C163A7E.6060701@mcs.anl.gov> Date: Mon, 14 Jun 2010 10:37:53 -0700 Message-ID: Subject: Re: minor file journal size bug From: Yehuda Sadeh Weinraub To: Phil Carns Cc: ceph-devel@vger.kernel.org Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 14 Jun 2010 17:38:13 +0000 (UTC) diff --git a/src/config.cc b/src/config.cc index 9615186..bb4e2c9 100644 --- a/src/config.cc +++ b/src/config.cc @@ -431,7 +431,7 @@ static struct config_option config_optionsp[] = { OPTION(mds_kill_import_at, 0, OPT_INT, 0), OPTION(osd_data, 0, OPT_STR, ""), OPTION(osd_journal, 0, OPT_STR, ""), - OPTION(osd_journal_size, 0, OPT_INT, 0), // in mb + OPTION(osd_journal_size, 0, OPT_LONGLONG, 0), // in mb OPTION(osd_balance_reads, 0, OPT_BOOL, false), OPTION(osd_flash_crowd_iat_threshold, 0, OPT_INT, 0), OPTION(osd_flash_crowd_iat_alpha, 0, OPT_DOUBLE, 0.125), diff --git a/src/config.h b/src/config.h index 68dca6f..45206f6 100644 --- a/src/config.h +++ b/src/config.h @@ -290,7 +290,7 @@ struct md_config_t { // osd const char *osd_data; const char *osd_journal; - int osd_journal_size; // in mb + long long osd_journal_size; // in mb bool osd_balance_reads; int osd_flash_crowd_iat_threshold; // flash crowd interarrival time threshold in ms