| Message ID | CABAwU-ZCSVbkLUOvZBd8=+uHD1L6tVS5iAkpDNUS0_myP5Xndw@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 21, 2014 at 4:27 AM, huang jun <hjwsm1989@gmail.com> wrote: > Signed-off-by: hjwsm1989<hjwsm1989@gmail.com> > > -- > diff --git a/ceph.spec.in b/ceph.spec.in > index 3caa849..facba6c 100644 > --- a/ceph.spec.in > +++ b/ceph.spec.in > @@ -429,6 +429,7 @@ fi > @@ -429,6 +429,7 @@ fi > %{_libdir}/rados-classes/libcls_log.so* > diff --git a/ceph.spec.in b/ceph.spec.in > index 3caa849..facba6c 100644 > --- a/ceph.spec.in > +++ b/ceph.spec.in > @@ -429,6 +429,7 @@ fi > %{_libdir}/rados-classes/libcls_replica_log.so* > %{_libdir}/rados-classes/libcls_statelog.so* > +%{_libdir}/rados-classes/libcls_user.so* Thanks for catching this. > @@ -690,6 +689,7 @@ fi > %{_bindir}/ceph_test_rados_list_parallel > %{_bindir}/ceph_test_rados_open_pools_parallel > %{_bindir}/ceph_test_rados_watch_notify > +%{_bindir}/ceph_test_rgw_manifest > %{_bindir}/ceph_test_signal_handlers > %{_bindir}/ceph_test_snap_mapper It seems like we have to deal with this sort of thing over and over. Anyone have objections to simply using a wildcard to capture all the test files? Something like %{_bindir}/ceph_test_* ? - Ken -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 21 Feb 2014, Ken Dreyer wrote: > On Fri, Feb 21, 2014 at 4:27 AM, huang jun <hjwsm1989@gmail.com> wrote: > > Signed-off-by: hjwsm1989<hjwsm1989@gmail.com> > > > > -- > > diff --git a/ceph.spec.in b/ceph.spec.in > > index 3caa849..facba6c 100644 > > --- a/ceph.spec.in > > +++ b/ceph.spec.in > > @@ -429,6 +429,7 @@ fi > > @@ -429,6 +429,7 @@ fi > > %{_libdir}/rados-classes/libcls_log.so* > > diff --git a/ceph.spec.in b/ceph.spec.in > > index 3caa849..facba6c 100644 > > --- a/ceph.spec.in > > +++ b/ceph.spec.in > > @@ -429,6 +429,7 @@ fi > > %{_libdir}/rados-classes/libcls_replica_log.so* > > %{_libdir}/rados-classes/libcls_statelog.so* > > +%{_libdir}/rados-classes/libcls_user.so* > > Thanks for catching this. > > > > @@ -690,6 +689,7 @@ fi > > %{_bindir}/ceph_test_rados_list_parallel > > %{_bindir}/ceph_test_rados_open_pools_parallel > > %{_bindir}/ceph_test_rados_watch_notify > > +%{_bindir}/ceph_test_rgw_manifest > > %{_bindir}/ceph_test_signal_handlers > > %{_bindir}/ceph_test_snap_mapper > > > It seems like we have to deal with this sort of thing over and over. > Anyone have objections to simply using a wildcard to capture all the > test files? Something like %{_bindir}/ceph_test_* ? Sounds good to me. This is only stuff that 'make install' is putting in place right? sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 21, 2014 at 1:48 PM, Sage Weil <sage@inktank.com> wrote: > On Fri, 21 Feb 2014, Ken Dreyer wrote: >> On Fri, Feb 21, 2014 at 4:27 AM, huang jun <hjwsm1989@gmail.com> wrote: >> > @@ -690,6 +689,7 @@ fi >> > %{_bindir}/ceph_test_rados_list_parallel >> > %{_bindir}/ceph_test_rados_open_pools_parallel >> > %{_bindir}/ceph_test_rados_watch_notify >> > +%{_bindir}/ceph_test_rgw_manifest >> > %{_bindir}/ceph_test_signal_handlers >> > %{_bindir}/ceph_test_snap_mapper >> >> >> It seems like we have to deal with this sort of thing over and over. >> Anyone have objections to simply using a wildcard to capture all the >> test files? Something like %{_bindir}/ceph_test_* ? > > Sounds good to me. This is only stuff that 'make install' is putting in > place right? Yep, that's right, the wildcard will just match what 'make install' has done. Pull request is at https://github.com/ceph/ceph/pull/1287 . Huang, if you have time, it would be great to get your review before we merge. - Ken -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ceph.spec.in b/ceph.spec.in index 3caa849..facba6c 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -429,6 +429,7 @@ fi @@ -429,6 +429,7 @@ fi %{_libdir}/rados-classes/libcls_log.so* diff --git a/ceph.spec.in b/ceph.spec.in index 3caa849..facba6c 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -429,6 +429,7 @@ fi %{_libdir}/rados-classes/libcls_replica_log.so*
Signed-off-by: hjwsm1989<hjwsm1989@gmail.com>