From patchwork Tue Oct 23 20:24:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yehuda Sadeh X-Patchwork-Id: 1632951 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id C1C86DF283 for ; Tue, 23 Oct 2012 20:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757547Ab2JWUYI (ORCPT ); Tue, 23 Oct 2012 16:24:08 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:53844 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757506Ab2JWUYG (ORCPT ); Tue, 23 Oct 2012 16:24:06 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so1778968bkc.19 for ; Tue, 23 Oct 2012 13:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=xiKNngxpNNifVcwrCfOuK9PG+Vnh3Tx5h4ztMnGYD9U=; b=OEh3sg2krxqziHAUCfVjro922hi0CccOQWvwL9ybVscdptEgjtWMjFPYPPoPeXL2kH CnCtbIUxQ9+0pt6PH8cE1xgwos7ipVKLzhLDXQ8mvlV8/YC6JWGzyiw80jG0Z1MC+SIg cVp9TuRUy0u7PBPwn3mBepfqdiP8srAChHD4CyGrCki61UUZw3+ugQ5UWjcW/oDZiKpc DaS+MMIVCWNBQZq+EBQbbNVuInY+XHdg+4ZoSb8gJWqlxEOp5htwhlfsD0aNaH43H5Q+ i7ja45hN28vG8YQX5zrmbncwnaQfAqwUAjw89nqoZX+rz77p2AoSv0RnG47Eow5niTQn ofaA== MIME-Version: 1.0 Received: by 10.204.11.194 with SMTP id u2mr4071051bku.41.1351023845173; Tue, 23 Oct 2012 13:24:05 -0700 (PDT) Received: by 10.204.35.79 with HTTP; Tue, 23 Oct 2012 13:24:05 -0700 (PDT) In-Reply-To: References: <5086FAC1.3030706@inktank.com> Date: Tue, 23 Oct 2012 13:24:05 -0700 X-Google-Sender-Auth: LKLHylklDvwnpUwi_Td4U4WM06E Message-ID: Subject: Re: running without cephx From: Yehuda Sadeh To: Dan Mick Cc: ceph-devel Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, Oct 23, 2012 at 1:22 PM, Yehuda Sadeh wrote: > On Tue, Oct 23, 2012 at 1:14 PM, Dan Mick wrote: >> So, I've discovered that to make "no cephx" work, you need to explicitly set >> "none" for the three options (thanks to Yehuda for the tip): >> >> auth cluster required = none >> auth service required = none >> auth supported = none >> >> Since "blank" is not an error, but leads to a disagreement about >> authentication that's fairly hard to diagnose, should we make it an error to >> specify a blank entry for those items? >> > Maybe fix it so that blank entries would be equivalent to 'none'? > > Yehuda That should do it: bool AuthMethodList::is_supported_auth(int auth_type) --- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/auth/AuthMethodList.cc b/src/auth/AuthMethodList.cc index e23ac40..53c8d66 100644 --- a/src/auth/AuthMethodList.cc +++ b/src/auth/AuthMethodList.cc @@ -35,6 +35,8 @@ AuthMethodList::AuthMethodList(CephContext *cct, string str) lderr(cct) << "WARNING: unknown auth protocol defined: " << *iter << dendl; } } + if (auth_supported.empty()) + auth_supported.push_back(CEPH_AUTH_NONE); }