From patchwork Tue Nov 28 06:38:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YuFan Chen X-Patchwork-Id: 10078743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7CDFC6056A for ; Tue, 28 Nov 2017 06:38:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38934289E8 for ; Tue, 28 Nov 2017 06:38:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B9D129087; Tue, 28 Nov 2017 06:38:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C4A55289E8 for ; Tue, 28 Nov 2017 06:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750907AbdK1GiF (ORCPT ); Tue, 28 Nov 2017 01:38:05 -0500 Received: from mail-it0-f49.google.com ([209.85.214.49]:36113 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdK1GiE (ORCPT ); Tue, 28 Nov 2017 01:38:04 -0500 Received: by mail-it0-f49.google.com with SMTP id y71so12696711ita.1 for ; Mon, 27 Nov 2017 22:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+VWcQ9SRzpjxN48jZ+N98aOW0gz7E/Psk/qDoiY6TIU=; b=RKLj/quv44wr7QxvIxleqeqlwZ6mDF9G6iP0P/bGI84r3MZz5/FiSys4zQOLGjPlYz LADb6mOZusuk+oNHZhVWQT3sIY1ZqQqTLGh09dPx2aVq7Q3lVkHSfwiT9SO812vMdOOx ENivzxNoxLBmL3H66ZgGShG49/XFwAUuFas+ShZ03hJtHKsZUHdpu9Ji+vaGv3VcWVf4 KmGp74U6WTDlB0ezav0YTAC6pPkHKChLi9H/1Qb/SYQNTru7GdNCI58zihmBKmc/Bk7f W5SNDU+gPSReskDVBn8941fik88CUogfhJuTlrr2JWNYwX/DVAagUTIv7/fp3MwjHigB 16Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+VWcQ9SRzpjxN48jZ+N98aOW0gz7E/Psk/qDoiY6TIU=; b=hYBpBQ+H14vmgeHf5kzcopq9nEFcc7o37yQDCcQqnTgLpxFgwBFvnl9kEarE03nrRn Wavr5QkXF05TH+E2XjWJ7hLDyTCTIVubNHejMolimzVvD1sq6tl/nBfGLnnW+WGFPAMi KasUcG47Pl/oSy50Rdp6Jf2HtA88O0J61IIriVuTvP9U3ErWrZNzTwAp5oZMbZOOlUze k94lyiwQOdBdnuDTZ5Hiy7hF027Wpt1YcnmgG3uho+YUztonyKPcW96yg6GehUQTIbdM G3ujljsLTqgvTc26rSTh5rMSFeVu/ilMZvFjvrfmmh7ruHFY2M7ykzetCCjhQ0Nzzy7B 4HYQ== X-Gm-Message-State: AJaThX5ctx5P3Y8UUymERW6n+GtmEKpVkjs011d4Gwkg3c1IaVJfXQ+5 gy2X8pYd2fUe9FONg8cEYdmY4h8qf4CwofMCEwWDGQ== X-Google-Smtp-Source: AGs4zMbMXmRz6RV/O4QjWlcfR1oiko6uujiRuIcPO4GGiNMM32bYR0Yid7Q5IFXs8uNcUTqN4d4EXoWJzeXeOEA5sp0= X-Received: by 10.36.19.81 with SMTP id 78mr1035608itz.143.1511851083454; Mon, 27 Nov 2017 22:38:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.14.211 with HTTP; Mon, 27 Nov 2017 22:38:03 -0800 (PST) From: YuFan Chen Date: Tue, 28 Nov 2017 14:38:03 +0800 Message-ID: Subject: About the "temperature histogram" of tier-agent To: ceph-devel@vger.kernel.org Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Before Jewel, the code uses "atime" to distinguish hot/cold data: agent_estimate_atime_temp() calculates the distance. It means colder data gets longer distance (larger value) In Jewel, it changes to use temperature with weight. So, colder data gets smaller value. However, it still use the "old semantics" to determine evicting or not in ReplicatedPG::agent_estimate_atime_temp(); if (1000000 - temp_upper >= agent_state->evict_effort) return false; if there is no misunderstanding, should it change to that: } Yu Fan --- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -12211,7 +12211,7 @@ bool ReplicatedPG::agent_maybe_evict(ObjectContextRef& obc, bool after_flush) delete f; *_dout << dendl; - if (1000000 - temp_upper >= agent_state->evict_effort) + if (temp_upper >= agent_state->evict_effort) return false;