diff mbox

rgw_rest.cc build failure

Message ID CAPrxi5-fb2hQeLcgC577JOLxZmMaKT=SYhCxzBwwUEDcxxLBvg@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Noah Watkins Oct. 10, 2012, 9:25 p.m. UTC
This needed for latest master:


to fix:

  CXX    radosgw-rgw_rest.o
rgw/rgw_rest.cc: In static member function ‘static int
RESTArgs::get_uint64(req_state*, const string&, uint64_t, uint64_t*,
bool*)’:
rgw/rgw_rest.cc:326:15: error: ‘ULLONG_MAX’ was not declared in this scope
rgw/rgw_rest.cc: In static member function ‘static int
RESTArgs::get_int64(req_state*, const string&, int64_t, int64_t*,
bool*)’:
rgw/rgw_rest.cc:351:15: error: ‘LLONG_MAX’ was not declared in this scope

- Noah
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Yehuda Sadeh Oct. 10, 2012, 9:29 p.m. UTC | #1
I'll apply this, can I assume you have signed off this patch?

On Wed, Oct 10, 2012 at 2:25 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>
> This needed for latest master:
>
> diff --git a/src/rgw/rgw_rest.cc b/src/rgw/rgw_rest.cc
> index 53bbeca..3612a9e 100644
> --- a/src/rgw/rgw_rest.cc
> +++ b/src/rgw/rgw_rest.cc
> @@ -1,4 +1,5 @@
>  #include <errno.h>
> +#include <limits.h>
>
>  #include "common/Formatter.h"
>  #include "common/utf8.h"
>
> to fix:
>
>   CXX    radosgw-rgw_rest.o
> rgw/rgw_rest.cc: In static member function ‘static int
> RESTArgs::get_uint64(req_state*, const string&, uint64_t, uint64_t*,
> bool*)’:
> rgw/rgw_rest.cc:326:15: error: ‘ULLONG_MAX’ was not declared in this scope
> rgw/rgw_rest.cc: In static member function ‘static int
> RESTArgs::get_int64(req_state*, const string&, int64_t, int64_t*,
> bool*)’:
> rgw/rgw_rest.cc:351:15: error: ‘LLONG_MAX’ was not declared in this scope
>
> - Noah
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Noah Watkins Oct. 10, 2012, 9:34 p.m. UTC | #2
On Wed, Oct 10, 2012 at 2:29 PM, Yehuda Sadeh <yehuda@inktank.com> wrote:
> I'll apply this, can I assume you have signed off this patch?

Ahh, yes, sorry.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

>
> On Wed, Oct 10, 2012 at 2:25 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
>>
>> This needed for latest master:
>>
>> diff --git a/src/rgw/rgw_rest.cc b/src/rgw/rgw_rest.cc
>> index 53bbeca..3612a9e 100644
>> --- a/src/rgw/rgw_rest.cc
>> +++ b/src/rgw/rgw_rest.cc
>> @@ -1,4 +1,5 @@
>>  #include <errno.h>
>> +#include <limits.h>
>>
>>  #include "common/Formatter.h"
>>  #include "common/utf8.h"
>>
>> to fix:
>>
>>   CXX    radosgw-rgw_rest.o
>> rgw/rgw_rest.cc: In static member function ‘static int
>> RESTArgs::get_uint64(req_state*, const string&, uint64_t, uint64_t*,
>> bool*)’:
>> rgw/rgw_rest.cc:326:15: error: ‘ULLONG_MAX’ was not declared in this scope
>> rgw/rgw_rest.cc: In static member function ‘static int
>> RESTArgs::get_int64(req_state*, const string&, int64_t, int64_t*,
>> bool*)’:
>> rgw/rgw_rest.cc:351:15: error: ‘LLONG_MAX’ was not declared in this scope
>>
>> - Noah
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/rgw/rgw_rest.cc b/src/rgw/rgw_rest.cc
index 53bbeca..3612a9e 100644
--- a/src/rgw/rgw_rest.cc
+++ b/src/rgw/rgw_rest.cc
@@ -1,4 +1,5 @@ 
 #include <errno.h>
+#include <limits.h>

 #include "common/Formatter.h"
 #include "common/utf8.h"