| Message ID | 20240327-b4-module-owner-acpi-v1-0-725241a2d224@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ACPI: store owner from modules with acpi_bus_register_driver() | expand |
On Wed, Mar 27, 2024 at 8:44 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Merging > ======= > All further patches depend on the first amba patch, therefore please ack > and this should go via one tree: ACPI? > > Description > =========== > Modules registering driver with acpi_bus_register_driver() often forget to > set .owner field. > > Solve the problem by moving this task away from the drivers to the core > amba bus code, just like we did for platform_driver in commit > 9447057eaff8 ("platform_device: use a macro instead of > platform_driver_register"). > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (19): > ACPI: store owner from modules with acpi_bus_register_driver() > Input: atlas: - drop owner assignment > net: fjes: drop owner assignment > platform: chrome: drop owner assignment > platform: asus-laptop: drop owner assignment > platform: classmate-laptop: drop owner assignment > platform/x86/dell: drop owner assignment > platform/x86/eeepc: drop owner assignment > platform/x86/intel/rst: drop owner assignment > platform/x86/intel/smartconnect: drop owner assignment > platform/x86/lg-laptop: drop owner assignment > platform/x86/sony-laptop: drop owner assignment > platform/x86/toshiba_acpi: drop owner assignment > platform/x86/toshiba_bluetooth: drop owner assignment > platform/x86/toshiba_haps: drop owner assignment > platform/x86/wireless-hotkey: drop owner assignment > ptp: vmw: drop owner assignment > virt: vmgenid: drop owner assignment > ACPI: drop redundant owner from acpi_driver I definitely like this, so Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> for the series and I can pick it up if people agree. Thanks!
Hi, On 3/27/24 2:16 PM, Rafael J. Wysocki wrote: > On Wed, Mar 27, 2024 at 8:44 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> Merging >> ======= >> All further patches depend on the first amba patch, therefore please ack >> and this should go via one tree: ACPI? >> >> Description >> =========== >> Modules registering driver with acpi_bus_register_driver() often forget to >> set .owner field. >> >> Solve the problem by moving this task away from the drivers to the core >> amba bus code, just like we did for platform_driver in commit >> 9447057eaff8 ("platform_device: use a macro instead of >> platform_driver_register"). >> >> Best regards, >> Krzysztof >> >> --- >> Krzysztof Kozlowski (19): >> ACPI: store owner from modules with acpi_bus_register_driver() >> Input: atlas: - drop owner assignment >> net: fjes: drop owner assignment >> platform: chrome: drop owner assignment >> platform: asus-laptop: drop owner assignment >> platform: classmate-laptop: drop owner assignment >> platform/x86/dell: drop owner assignment >> platform/x86/eeepc: drop owner assignment >> platform/x86/intel/rst: drop owner assignment >> platform/x86/intel/smartconnect: drop owner assignment >> platform/x86/lg-laptop: drop owner assignment >> platform/x86/sony-laptop: drop owner assignment >> platform/x86/toshiba_acpi: drop owner assignment >> platform/x86/toshiba_bluetooth: drop owner assignment >> platform/x86/toshiba_haps: drop owner assignment >> platform/x86/wireless-hotkey: drop owner assignment >> ptp: vmw: drop owner assignment >> virt: vmgenid: drop owner assignment >> ACPI: drop redundant owner from acpi_driver > > I definitely like this, so > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > for the series and I can pick it up if people agree. > > Thanks! >
Hi, <sorry for the empty previous reply, my bad> On 3/27/24 2:16 PM, Rafael J. Wysocki wrote: > On Wed, Mar 27, 2024 at 8:44 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> Merging >> ======= >> All further patches depend on the first amba patch, therefore please ack >> and this should go via one tree: ACPI? >> >> Description >> =========== >> Modules registering driver with acpi_bus_register_driver() often forget to >> set .owner field. >> >> Solve the problem by moving this task away from the drivers to the core >> amba bus code, just like we did for platform_driver in commit >> 9447057eaff8 ("platform_device: use a macro instead of >> platform_driver_register"). >> >> Best regards, >> Krzysztof >> >> --- >> Krzysztof Kozlowski (19): >> ACPI: store owner from modules with acpi_bus_register_driver() >> Input: atlas: - drop owner assignment >> net: fjes: drop owner assignment >> platform: chrome: drop owner assignment >> platform: asus-laptop: drop owner assignment >> platform: classmate-laptop: drop owner assignment >> platform/x86/dell: drop owner assignment >> platform/x86/eeepc: drop owner assignment >> platform/x86/intel/rst: drop owner assignment >> platform/x86/intel/smartconnect: drop owner assignment >> platform/x86/lg-laptop: drop owner assignment >> platform/x86/sony-laptop: drop owner assignment >> platform/x86/toshiba_acpi: drop owner assignment >> platform/x86/toshiba_bluetooth: drop owner assignment >> platform/x86/toshiba_haps: drop owner assignment >> platform/x86/wireless-hotkey: drop owner assignment >> ptp: vmw: drop owner assignment >> virt: vmgenid: drop owner assignment >> ACPI: drop redundant owner from acpi_driver > > I definitely like this, so > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > for the series and I can pick it up if people agree. Thanks all the drivers/platform/x86/* change look good to me: Acked-by: Hans de Goede <hdegoede@redhat.com> And I'm fine with merging these through the linux-pm / ACPI tree. Regards, Hans
Merging ======= All further patches depend on the first amba patch, therefore please ack and this should go via one tree: ACPI? Description =========== Modules registering driver with acpi_bus_register_driver() often forget to set .owner field. Solve the problem by moving this task away from the drivers to the core amba bus code, just like we did for platform_driver in commit 9447057eaff8 ("platform_device: use a macro instead of platform_driver_register"). Best regards, Krzysztof --- Krzysztof Kozlowski (19): ACPI: store owner from modules with acpi_bus_register_driver() Input: atlas: - drop owner assignment net: fjes: drop owner assignment platform: chrome: drop owner assignment platform: asus-laptop: drop owner assignment platform: classmate-laptop: drop owner assignment platform/x86/dell: drop owner assignment platform/x86/eeepc: drop owner assignment platform/x86/intel/rst: drop owner assignment platform/x86/intel/smartconnect: drop owner assignment platform/x86/lg-laptop: drop owner assignment platform/x86/sony-laptop: drop owner assignment platform/x86/toshiba_acpi: drop owner assignment platform/x86/toshiba_bluetooth: drop owner assignment platform/x86/toshiba_haps: drop owner assignment platform/x86/wireless-hotkey: drop owner assignment ptp: vmw: drop owner assignment virt: vmgenid: drop owner assignment ACPI: drop redundant owner from acpi_driver drivers/acpi/bus.c | 9 +++++---- drivers/input/misc/atlas_btns.c | 1 - drivers/net/fjes/fjes_main.c | 1 - drivers/platform/chrome/wilco_ec/event.c | 1 - drivers/platform/x86/asus-laptop.c | 1 - drivers/platform/x86/classmate-laptop.c | 5 ----- drivers/platform/x86/dell/dell-rbtn.c | 1 - drivers/platform/x86/eeepc-laptop.c | 1 - drivers/platform/x86/intel/rst.c | 1 - drivers/platform/x86/intel/smartconnect.c | 1 - drivers/platform/x86/lg-laptop.c | 1 - drivers/platform/x86/sony-laptop.c | 2 -- drivers/platform/x86/toshiba_acpi.c | 1 - drivers/platform/x86/toshiba_bluetooth.c | 1 - drivers/platform/x86/toshiba_haps.c | 1 - drivers/platform/x86/wireless-hotkey.c | 1 - drivers/ptp/ptp_vmw.c | 1 - drivers/virt/vmgenid.c | 1 - include/acpi/acpi_bus.h | 8 ++++++-- 19 files changed, 11 insertions(+), 28 deletions(-) --- base-commit: 1fdad13606e104ff103ca19d2d660830cb36d43e change-id: 20240327-b4-module-owner-acpi-d4948a922351 Best regards,