mbox series

[v3,0/2] platform/chrome: cros_ec: improve probing for RWSIG

Message ID 20241206091514.2538350-1-dawidn@google.com (mailing list archive)
Headers show
Series platform/chrome: cros_ec: improve probing for RWSIG | expand

Message

Dawid Niedzwiecki Dec. 6, 2024, 9:15 a.m. UTC 
V2 -> V3:
- Move exiting from `cros_ec_rwsig_continue` if `error_count` exceeds
  `RWSIG_CONTINUE_MAX_ERRORS_IN_ROW` to the `if (rev < 0)` statement when
  `error_count` is incremented.

V1 -> V2:
- Use dev_info instead of dev_warn when cros_ec_rwsig_continue returns
  an error.
- Return immediately from cros_ec_rwsig_continue, if the RWSIG_ACTION
  command fails itself, not SPI transaction.

Dawid Niedzwiecki (2):
  platform/chrome: cros_ec: jump to RW before probing
  platform/chrome: cros_ec_proto: remove unnecessary retries

 drivers/platform/chrome/cros_ec.c           |  5 ++
 drivers/platform/chrome/cros_ec_i2c.c       |  3 +-
 drivers/platform/chrome/cros_ec_ishtp.c     |  2 +-
 drivers/platform/chrome/cros_ec_lpc.c       |  2 +-
 drivers/platform/chrome/cros_ec_proto.c     | 69 ++++++++++++++++++---
 drivers/platform/chrome/cros_ec_rpmsg.c     |  2 +-
 drivers/platform/chrome/cros_ec_spi.c       |  2 +-
 drivers/platform/chrome/cros_ec_uart.c      |  2 +-
 include/linux/platform_data/cros_ec_proto.h |  2 +
 9 files changed, 74 insertions(+), 15 deletions(-)

Comments

Tzung-Bi Shih Dec. 9, 2024, 2:20 a.m. UTC | #1 
On Fri, Dec 06, 2024 at 09:15:12AM +0000, Dawid Niedzwiecki wrote:
> V2 -> V3:
> - Move exiting from `cros_ec_rwsig_continue` if `error_count` exceeds
>   `RWSIG_CONTINUE_MAX_ERRORS_IN_ROW` to the `if (rev < 0)` statement when
>   `error_count` is incremented.
> 
> V1 -> V2:
> - Use dev_info instead of dev_warn when cros_ec_rwsig_continue returns
>   an error.
> - Return immediately from cros_ec_rwsig_continue, if the RWSIG_ACTION
>   command fails itself, not SPI transaction.
> 
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/2] platform/chrome: cros_ec: jump to RW before probing
      commit: 4b308a1944b8ff1d50131849372672396a799a37
[2/2] platform/chrome: cros_ec_proto: remove unnecessary retries
      commit: bd37caa72a61fea3c1ddf465ed1b122b6a613349

Thanks!