| Message ID | 20220209095703.517608-7-tzungbi@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | platform/chrome: cros_ec: miscellaneous cleanups | expand |
On Feb 09 17:57, Tzung-Bi Shih wrote: > To be consistent, append newline ("\n") to all logs. > > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> Reviewed-by: Prashant Malani <pmalani@chromium.org> > --- > No changes from v2. > > Changes from v1: > (https://lore.kernel.org/lkml/20220125101527.1812887-1-tzungbi@google.com/T/#u) > - Use imperative mood in commit message. > > drivers/platform/chrome/cros_ec.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c > index 2c4e81f3fef9..639d5a651b76 100644 > --- a/drivers/platform/chrome/cros_ec.c > +++ b/drivers/platform/chrome/cros_ec.c > @@ -213,7 +213,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > IRQF_TRIGGER_LOW | IRQF_ONESHOT, > "chromeos-ec", ec_dev); > if (err) { > - dev_err(dev, "Failed to request IRQ %d: %d", > + dev_err(dev, "Failed to request IRQ %d: %d\n", > ec_dev->irq, err); > return err; > } > @@ -264,7 +264,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > */ > err = cros_ec_sleep_event(ec_dev, 0); > if (err < 0) > - dev_dbg(ec_dev->dev, "Error %d clearing sleep event to ec", > + dev_dbg(ec_dev->dev, "Error %d clearing sleep event to ec\n", > err); > > if (ec_dev->mkbp_event_supported) { > @@ -336,7 +336,7 @@ int cros_ec_suspend(struct cros_ec_device *ec_dev) > > ret = cros_ec_sleep_event(ec_dev, sleep_event); > if (ret < 0) > - dev_dbg(ec_dev->dev, "Error %d sending suspend event to ec", > + dev_dbg(ec_dev->dev, "Error %d sending suspend event to ec\n", > ret); > > if (device_may_wakeup(dev)) > @@ -381,7 +381,7 @@ int cros_ec_resume(struct cros_ec_device *ec_dev) > > ret = cros_ec_sleep_event(ec_dev, sleep_event); > if (ret < 0) > - dev_dbg(ec_dev->dev, "Error %d sending resume event to ec", > + dev_dbg(ec_dev->dev, "Error %d sending resume event to ec\n", > ret); > > if (ec_dev->wake_enabled) > -- > 2.35.0.263.gb82422642f-goog >
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index 2c4e81f3fef9..639d5a651b76 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -213,7 +213,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) IRQF_TRIGGER_LOW | IRQF_ONESHOT, "chromeos-ec", ec_dev); if (err) { - dev_err(dev, "Failed to request IRQ %d: %d", + dev_err(dev, "Failed to request IRQ %d: %d\n", ec_dev->irq, err); return err; } @@ -264,7 +264,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) */ err = cros_ec_sleep_event(ec_dev, 0); if (err < 0) - dev_dbg(ec_dev->dev, "Error %d clearing sleep event to ec", + dev_dbg(ec_dev->dev, "Error %d clearing sleep event to ec\n", err); if (ec_dev->mkbp_event_supported) { @@ -336,7 +336,7 @@ int cros_ec_suspend(struct cros_ec_device *ec_dev) ret = cros_ec_sleep_event(ec_dev, sleep_event); if (ret < 0) - dev_dbg(ec_dev->dev, "Error %d sending suspend event to ec", + dev_dbg(ec_dev->dev, "Error %d sending suspend event to ec\n", ret); if (device_may_wakeup(dev)) @@ -381,7 +381,7 @@ int cros_ec_resume(struct cros_ec_device *ec_dev) ret = cros_ec_sleep_event(ec_dev, sleep_event); if (ret < 0) - dev_dbg(ec_dev->dev, "Error %d sending resume event to ec", + dev_dbg(ec_dev->dev, "Error %d sending resume event to ec\n", ret); if (ec_dev->wake_enabled)
To be consistent, append newline ("\n") to all logs. Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> --- No changes from v2. Changes from v1: (https://lore.kernel.org/lkml/20220125101527.1812887-1-tzungbi@google.com/T/#u) - Use imperative mood in commit message. drivers/platform/chrome/cros_ec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)