| Message ID | 20220712214554.545035-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ce838f7dc7957afb2846c3bc537db56e4c513390 |
| Headers | show |
| Series | platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail | expand |
On Tue, Jul 12, 2022 at 2:46 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > The typec_register_port() can fail with EPROBE_DEFER if the endpoint > node hasn't probed yet. In order to avoid spamming the log with errors > in that case, log using dev_err_probe(). > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> > > --- > > drivers/platform/chrome/cros_ec_typec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index d6088ba447af..8c0ca3c128ee 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -352,8 +352,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) > > cros_port->port = typec_register_port(dev, cap); > if (IS_ERR(cros_port->port)) { > - dev_err(dev, "Failed to register port %d\n", port_num); > ret = PTR_ERR(cros_port->port); > + dev_err_probe(dev, ret, "Failed to register port %d\n", port_num); > goto unregister_ports; > } > > -- > 2.37.0 >
Il 12/07/22 23:45, Nícolas F. R. A. Prado ha scritto: > The typec_register_port() can fail with EPROBE_DEFER if the endpoint > node hasn't probed yet. In order to avoid spamming the log with errors > in that case, log using dev_err_probe(). > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Prashant Malani <pmalani@chromium.org>: On Tue, 12 Jul 2022 17:45:54 -0400 you wrote: > The typec_register_port() can fail with EPROBE_DEFER if the endpoint > node hasn't probed yet. In order to avoid spamming the log with errors > in that case, log using dev_err_probe(). > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > [...] Here is the summary with links: - platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail https://git.kernel.org/chrome-platform/c/ce838f7dc795 You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Prashant Malani <pmalani@chromium.org>: On Tue, 12 Jul 2022 17:45:54 -0400 you wrote: > The typec_register_port() can fail with EPROBE_DEFER if the endpoint > node hasn't probed yet. In order to avoid spamming the log with errors > in that case, log using dev_err_probe(). > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > > [...] Here is the summary with links: - platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail https://git.kernel.org/chrome-platform/c/ce838f7dc795 You are awesome, thank you!
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index d6088ba447af..8c0ca3c128ee 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -352,8 +352,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) cros_port->port = typec_register_port(dev, cap); if (IS_ERR(cros_port->port)) { - dev_err(dev, "Failed to register port %d\n", port_num); ret = PTR_ERR(cros_port->port); + dev_err_probe(dev, ret, "Failed to register port %d\n", port_num); goto unregister_ports; }
The typec_register_port() can fail with EPROBE_DEFER if the endpoint node hasn't probed yet. In order to avoid spamming the log with errors in that case, log using dev_err_probe(). Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- drivers/platform/chrome/cros_ec_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)