| Message ID | 20220819190807.1275937-2-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1903adae0464c1e1c36b132db474cb3aff7bc727 |
| Headers | show |
| Series | platform/chrome: cros_ec_typec: Altmode fixes | expand |
On Fri, Aug 19, 2022 at 07:08:02PM +0000, Prashant Malani wrote: > Use the right macro while constructing the DP_PORT_VDO to ensure the Pin > Assignment offsets are correct. > > Fixes: 1ff5d97f070c ("platform/chrome: cros_ec_typec: Register port altmodes") > Signed-off-by: Prashant Malani <pmalani@chromium.org> I have no idea but use your judgment: Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
On Fri, Aug 19, 2022 at 07:08:02PM +0000, Prashant Malani wrote: > Use the right macro while constructing the DP_PORT_VDO to ensure the Pin > Assignment offsets are correct. > > Fixes: 1ff5d97f070c ("platform/chrome: cros_ec_typec: Register port altmodes") > Signed-off-by: Prashant Malani <pmalani@chromium.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/platform/chrome/cros_ec_typec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index de6ee0f926a6..4d81d8d45b73 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -25,7 +25,8 @@ > > #define DRV_NAME "cros-ec-typec" > > -#define DP_PORT_VDO (BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D) | DP_CAP_DFP_D) > +#define DP_PORT_VDO (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \ > + DP_CAP_DFP_D) > > /* Supported alt modes. */ > enum { > -- > 2.37.1.595.g718a3a8f04-goog
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index de6ee0f926a6..4d81d8d45b73 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -25,7 +25,8 @@ #define DRV_NAME "cros-ec-typec" -#define DP_PORT_VDO (BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D) | DP_CAP_DFP_D) +#define DP_PORT_VDO (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \ + DP_CAP_DFP_D) /* Supported alt modes. */ enum {
Use the right macro while constructing the DP_PORT_VDO to ensure the Pin Assignment offsets are correct. Fixes: 1ff5d97f070c ("platform/chrome: cros_ec_typec: Register port altmodes") Signed-off-by: Prashant Malani <pmalani@chromium.org> --- drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)