| Message ID | 20220819190807.1275937-3-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4e477663e396f48c5cfc5f2d75d4b514f409516a |
| Headers | show |
| Series | platform/chrome: cros_ec_typec: Altmode fixes | expand |
On Fri, Aug 19, 2022 at 07:08:03PM +0000, Prashant Malani wrote: > Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. > > Update the alt mdoe registration code to factor this in to the alt mode > descriptor. > > Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes") > Signed-off-by: Prashant Malani <pmalani@chromium.org> I have no idea but use your judgment: Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Hi, On Fri, Aug 19, 2022 at 07:08:03PM +0000, Prashant Malani wrote: > Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. > > Update the alt mdoe registration code to factor this in to the alt mode > descriptor. > > Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes") > Signed-off-by: Prashant Malani <pmalani@chromium.org> Shouldn't this be applied also to the stable kernels? Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/platform/chrome/cros_ec_typec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 4d81d8d45b73..dc5722db2066 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -698,7 +698,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_ > for (j = 0; j < sop_disc->svids[i].mode_count; j++) { > memset(&desc, 0, sizeof(desc)); > desc.svid = sop_disc->svids[i].svid; > - desc.mode = j; > + desc.mode = j + 1; > desc.vdo = sop_disc->svids[i].mode_vdo[j]; > > if (is_partner) > -- > 2.37.1.595.g718a3a8f04-goog
Hi Heikki, Thanks for the review. On Tue, Aug 23, 2022 at 1:14 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > Hi, > > On Fri, Aug 19, 2022 at 07:08:03PM +0000, Prashant Malani wrote: > > Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. > > > > Update the alt mdoe registration code to factor this in to the alt mode > > descriptor. > > > > Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes") > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > > Shouldn't this be applied also to the stable kernels? We're not planning on backporting alt mode driver stuff to older kernels, so probably not necessary (aside from where it gets auto-magically picked). Userspace currently doesn't use the mode index for anything. Please LMK if you still feel it should go to stable. > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> >
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 4d81d8d45b73..dc5722db2066 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -698,7 +698,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_ for (j = 0; j < sop_disc->svids[i].mode_count; j++) { memset(&desc, 0, sizeof(desc)); desc.svid = sop_disc->svids[i].svid; - desc.mode = j; + desc.mode = j + 1; desc.vdo = sop_disc->svids[i].mode_vdo[j]; if (is_partner)
Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. Update the alt mdoe registration code to factor this in to the alt mode descriptor. Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes") Signed-off-by: Prashant Malani <pmalani@chromium.org> --- drivers/platform/chrome/cros_ec_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)