diff mbox series

[v2] platform/chrome: cros_ec: Notify the PM of wake events during resume

Message ID 20220912224745.2716345-1-jthies@google.com (mailing list archive)
State Superseded
Headers show
Series [v2] platform/chrome: cros_ec: Notify the PM of wake events during resume | expand

Commit Message

Jameson Thies Sept. 12, 2022, 10:47 p.m. UTC 
Update cros_ec_report_events_during_suspend to notify the PM of wake
events during resume by calling pm_wakeup_event.

Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
---

Changes since v1:
- Updated wording in commit message from "Log" to "Notify PM of".
---
 drivers/platform/chrome/cros_ec.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Tzung-Bi Shih Sept. 13, 2022, 3:14 a.m. UTC | #1 
On Mon, Sep 12, 2022 at 10:47:45PM +0000, Jameson Thies wrote:
> Update cros_ec_report_events_during_suspend to notify the PM of wake
> events during resume by calling pm_wakeup_event.

Could you add some more details about "why"?

> Signed-off-by: Jameson Thies <jthies@google.com>
> Reviewed-by: Prashant Malani <pmalani@chromium.org>

I didn't see where the R-b tag comes from which has been attached since
v1.  You shouldn't attach the tag even if the patch may have been
reviewed somewhere but not in the mailing list.
Prashant Malani Sept. 13, 2022, 5:16 p.m. UTC | #2 
On Mon, Sep 12, 2022 at 8:14 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Mon, Sep 12, 2022 at 10:47:45PM +0000, Jameson Thies wrote:
> > Update cros_ec_report_events_during_suspend to notify the PM of wake
> > events during resume by calling pm_wakeup_event.
>
> Could you add some more details about "why"?
>
> > Signed-off-by: Jameson Thies <jthies@google.com>
> > Reviewed-by: Prashant Malani <pmalani@chromium.org>
>
> I didn't see where the R-b tag comes from which has been attached since
> v1.

I asked Jameson to do so, after having reviewed the patch off list.

> You shouldn't attach the tag even if the patch may have been
> reviewed somewhere but not in the mailing list.

That is not a requirement (at least, it is not stated anywhere in
kernel documentation).
There are plenty of examples of patches being uploaded after being
reviewed. Here
is just 1 recent example [1] but I'm sure you can find plenty more.

[1] https://lore.kernel.org/linux-usb/20220913055316.23050-2-shruthi.sanil@intel.com/
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 8aace50d446d..110df0fd4b00 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -349,10 +349,16 @@  EXPORT_SYMBOL(cros_ec_suspend);
 
 static void cros_ec_report_events_during_suspend(struct cros_ec_device *ec_dev)
 {
+	bool wake_event;
+
 	while (ec_dev->mkbp_event_supported &&
-	       cros_ec_get_next_event(ec_dev, NULL, NULL) > 0)
+	       cros_ec_get_next_event(ec_dev, &wake_event, NULL) > 0) {
 		blocking_notifier_call_chain(&ec_dev->event_notifier,
 					     1, ec_dev);
+
+		if (wake_event && device_may_wakeup(ec_dev->dev))
+			pm_wakeup_event(ec_dev->dev, 0);
+	}
 }
 
 /**