| Message ID | 20221101152132.v2.1.I0728421299079b104710c202d5d7095b2674fd8c@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fdf84f9ae30b40e3707359bcd467173b9d43454c |
| Headers | show |
| Series | [v2,1/5] platform/chrome: cros_ec_lpc: Move mec_init to device probe | expand |
Hello: This series was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Tue, 1 Nov 2022 15:22:06 -0700 you wrote: > Disregarding the weird global state hiding in this cros_ec_lpc_mec_*() > stuff, it belongs in device probe. We shouldn't assume we can access > hardware resources when the device isn't attached to the driver. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > > [...] Here is the summary with links: - [v2,1/5] platform/chrome: cros_ec_lpc: Move mec_init to device probe https://git.kernel.org/chrome-platform/c/fdf84f9ae30b - [v2,2/5] platform/chrome: cros_ec_lpc: Mark PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/bd88b965ae8c - [v2,3/5] platform/chrome: cros_ec_debugfs: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/692a68ad7f3c - [v2,4/5] platform/chrome: cros_ec_lightbar: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/873ab3e886b5 - [v2,5/5] platform/chrome: cros_ec_spi: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/015e4b05c377 You are awesome, thank you!
Hello: This series was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <tzungbi@kernel.org>: On Tue, 1 Nov 2022 15:22:06 -0700 you wrote: > Disregarding the weird global state hiding in this cros_ec_lpc_mec_*() > stuff, it belongs in device probe. We shouldn't assume we can access > hardware resources when the device isn't attached to the driver. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > > [...] Here is the summary with links: - [v2,1/5] platform/chrome: cros_ec_lpc: Move mec_init to device probe https://git.kernel.org/chrome-platform/c/fdf84f9ae30b - [v2,2/5] platform/chrome: cros_ec_lpc: Mark PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/bd88b965ae8c - [v2,3/5] platform/chrome: cros_ec_debugfs: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/692a68ad7f3c - [v2,4/5] platform/chrome: cros_ec_lightbar: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/873ab3e886b5 - [v2,5/5] platform/chrome: cros_ec_spi: Set PROBE_PREFER_ASYNCHRONOUS https://git.kernel.org/chrome-platform/c/015e4b05c377 You are awesome, thank you!
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 6ef5e5d40ba4..48302183d62e 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -354,6 +354,9 @@ static int cros_ec_lpc_probe(struct platform_device *pdev) return -EBUSY; } + cros_ec_lpc_mec_init(EC_HOST_CMD_REGION0, + EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SIZE); + /* * Read the mapped ID twice, the first one is assuming the * EC is a Microchip Embedded Controller (MEC) variant, if the @@ -586,9 +589,6 @@ static int __init cros_ec_lpc_init(void) return -ENODEV; } - cros_ec_lpc_mec_init(EC_HOST_CMD_REGION0, - EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SIZE); - /* Register the driver */ ret = platform_driver_register(&cros_ec_lpc_driver); if (ret) {
Disregarding the weird global state hiding in this cros_ec_lpc_mec_*() stuff, it belongs in device probe. We shouldn't assume we can access hardware resources when the device isn't attached to the driver. Signed-off-by: Brian Norris <briannorris@chromium.org> --- Changes in v2: - drop cros_ec_lpc_mec_destroy() (removed in -next; was done wrong in my v1 anyway) drivers/platform/chrome/cros_ec_lpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)