diff mbox series

[v10,2/3] dt-bindings: mfd: Add compatible string for UART support

Message ID 20221207104005.v10.2.I9e018ecb8bdf341648cb64417085978ff0d22a46@changeid (mailing list archive)
State Superseded
Headers show
Series [v10,1/3] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer | expand

Commit Message

Mark Hasemeyer Dec. 7, 2022, 5:40 p.m. UTC 
From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>

Add a compatible string to support the UART implementation of the cros
ec interface. The driver does not support the reg and interrupt
properties, so exempt them from being required for UART compatible nodes.

Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Changes in v10:
- No change

Changes in v9:
- Rebase onto for-next
- Update node-name from uart0 to serial
- Remove reg and interrupt property requirement for UART compatible
  nodes.
- Update authorship

Changes in v8:
- Update commit message

Changes in v7:
- No change

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- Changes in commit message.

Changes in v3:
- Rebased changes on google,cros-ec.yaml

Changes in v2:
- No change

---
 .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Krzysztof Kozlowski Dec. 7, 2022, 5:57 p.m. UTC | #1 
On 07/12/2022 18:40, Mark Hasemeyer wrote:
> From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> 
> Add a compatible string to support the UART implementation of the cros
> ec interface. The driver does not support the reg and interrupt
> properties, so exempt them from being required for UART compatible nodes.
> 
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Use subject prefixes matching the subsystem (git log --oneline -- ...)
and device. Currently it looks like you change ENTIRE MFD subsystem.

> ---
> 
> Changes in v10:
> - No change
> 

Best regards,
Krzysztof
Lee Jones Jan. 4, 2023, 4:08 p.m. UTC | #2 
On Wed, 07 Dec 2022, Mark Hasemeyer wrote:

> From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> 
> Add a compatible string to support the UART implementation of the cros
> ec interface. The driver does not support the reg and interrupt
> properties, so exempt them from being required for UART compatible nodes.
> 
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Changes in v10:
> - No change
> 
> Changes in v9:
> - Rebase onto for-next
> - Update node-name from uart0 to serial
> - Remove reg and interrupt property requirement for UART compatible
>   nodes.
> - Update authorship
> 
> Changes in v8:
> - Update commit message
> 
> Changes in v7:
> - No change
> 
> Changes in v6:
> - No change
> 
> Changes in v5:
> - No change
> 
> Changes in v4:
> - Changes in commit message.
> 
> Changes in v3:
> - Rebased changes on google,cros-ec.yaml
> 
> Changes in v2:
> - No change
> 
> ---
>  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)

I changed the subject line and applied the patch, thanks.
Tzung-Bi Shih Jan. 5, 2023, 1:10 a.m. UTC | #3 
On Wed, Jan 04, 2023 at 04:08:24PM +0000, Lee Jones wrote:
> On Wed, 07 Dec 2022, Mark Hasemeyer wrote:
> 
> > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > 
> > Add a compatible string to support the UART implementation of the cros
> > ec interface. The driver does not support the reg and interrupt
> > properties, so exempt them from being required for UART compatible nodes.
> > 
> > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > 
> > Changes in v10:
> > - No change
> > 
[...]
> 
> I changed the subject line and applied the patch, thanks.

Pardon me.  I didn't know you would pick the patch so that I have queued it
into chrome-platform[1].  Would you like me to drop the commit?

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/commit/?h=for-next&id=5be8cd61dcddfaee5d92072073672037154e76f5
Lee Jones Jan. 5, 2023, 2:13 p.m. UTC | #4 
On Thu, 05 Jan 2023, Tzung-Bi Shih wrote:

> On Wed, Jan 04, 2023 at 04:08:24PM +0000, Lee Jones wrote:
> > On Wed, 07 Dec 2022, Mark Hasemeyer wrote:
> > 
> > > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > 
> > > Add a compatible string to support the UART implementation of the cros
> > > ec interface. The driver does not support the reg and interrupt
> > > properties, so exempt them from being required for UART compatible nodes.
> > > 
> > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > ---
> > > 
> > > Changes in v10:
> > > - No change
> > > 
> [...]
> > 
> > I changed the subject line and applied the patch, thanks.
> 
> Pardon me.  I didn't know you would pick the patch so that I have queued it
> into chrome-platform[1].  Would you like me to drop the commit?


> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/commit/?h=for-next&id=5be8cd61dcddfaee5d92072073672037154e76f5
Lee Jones Jan. 5, 2023, 2:24 p.m. UTC | #5 
On Thu, 05 Jan 2023, Tzung-Bi Shih wrote:

> On Wed, Jan 04, 2023 at 04:08:24PM +0000, Lee Jones wrote:
> > On Wed, 07 Dec 2022, Mark Hasemeyer wrote:
> > 
> > > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > 
> > > Add a compatible string to support the UART implementation of the cros
> > > ec interface. The driver does not support the reg and interrupt
> > > properties, so exempt them from being required for UART compatible nodes.
> > > 
> > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > ---
> > > 
> > > Changes in v10:
> > > - No change
> > > 
> [...]
> > 
> > I changed the subject line and applied the patch, thanks.
> 
> Pardon me.  I didn't know you would pick the patch so that I have queued it
> into chrome-platform[1].  Would you like me to drop the commit?

Yes, please do.

You should gain permission from the maintainer before you apply patches.

  % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
     Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
     Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
     Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
 
 Why do I get the feeling we've had this conversation before?
Tzung-Bi Shih Jan. 5, 2023, 3:35 p.m. UTC | #6 
On Thu, Jan 05, 2023 at 02:24:26PM +0000, Lee Jones wrote:
> On Thu, 05 Jan 2023, Tzung-Bi Shih wrote:
> 
> > On Wed, Jan 04, 2023 at 04:08:24PM +0000, Lee Jones wrote:
> > > On Wed, 07 Dec 2022, Mark Hasemeyer wrote:
> > > 
> > > > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > > 
> > > > Add a compatible string to support the UART implementation of the cros
> > > > ec interface. The driver does not support the reg and interrupt
> > > > properties, so exempt them from being required for UART compatible nodes.
> > > > 
> > > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > > Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> > > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > ---
> > > > 
> > > > Changes in v10:
> > > > - No change
> > > > 
> > [...]
> > > 
> > > I changed the subject line and applied the patch, thanks.
> > 
> > Pardon me.  I didn't know you would pick the patch so that I have queued it
> > into chrome-platform[1].  Would you like me to drop the commit?
> 
> Yes, please do.

Dropped in chrome-platform.

> You should gain permission from the maintainer before you apply patches.
> 
>   % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
>      Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
>      Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>      Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>      Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)

I see.  I guess for the case, I should get both MFD and DT bindings
maintainers' Acks before applying the patch.
Lee Jones Jan. 5, 2023, 4:27 p.m. UTC | #7 
On Thu, 05 Jan 2023, Tzung-Bi Shih wrote:

> On Thu, Jan 05, 2023 at 02:24:26PM +0000, Lee Jones wrote:
> > On Thu, 05 Jan 2023, Tzung-Bi Shih wrote:
> > 
> > > On Wed, Jan 04, 2023 at 04:08:24PM +0000, Lee Jones wrote:
> > > > On Wed, 07 Dec 2022, Mark Hasemeyer wrote:
> > > > 
> > > > > From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > > > 
> > > > > Add a compatible string to support the UART implementation of the cros
> > > > > ec interface. The driver does not support the reg and interrupt
> > > > > properties, so exempt them from being required for UART compatible nodes.
> > > > > 
> > > > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > > > > Co-developed-by: Mark Hasemeyer <markhas@chromium.org>
> > > > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > ---
> > > > > 
> > > > > Changes in v10:
> > > > > - No change
> > > > > 
> > > [...]
> > > > 
> > > > I changed the subject line and applied the patch, thanks.
> > > 
> > > Pardon me.  I didn't know you would pick the patch so that I have queued it
> > > into chrome-platform[1].  Would you like me to drop the commit?
> > 
> > Yes, please do.
> 
> Dropped in chrome-platform.
> 
> > You should gain permission from the maintainer before you apply patches.
> > 
> >   % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> >      Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> >      Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >      Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >      Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> 
> I see.  I guess for the case, I should get both MFD and DT bindings
> maintainers' Acks before applying the patch.

Yes.  The situation isn't overly clear and differs from subsystem to
subsystem and maintainer to maintainer.  In the MFD case, Rob and
Krzysztof conduct the first reviews.  99 times out of 100, if they're
happy, I'm happy and I merge the changes via the MFD tree.  Same goes
for Backlight and more recently, LEDs.
Tzung-Bi Shih Jan. 5, 2023, 6:08 p.m. UTC | #8 
On Thu, Jan 05, 2023 at 04:27:32PM +0000, Lee Jones wrote:
> > > You should gain permission from the maintainer before you apply patches.
> > > 
> > >   % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > >      Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> > >      Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > >      Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > >      Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> > 
> > I see.  I guess for the case, I should get both MFD and DT bindings
> > maintainers' Acks before applying the patch.
> 
> Yes.  The situation isn't overly clear and differs from subsystem to
> subsystem and maintainer to maintainer.  In the MFD case, Rob and
> Krzysztof conduct the first reviews.  99 times out of 100, if they're
> happy, I'm happy and I merge the changes via the MFD tree.  Same goes
> for Backlight and more recently, LEDs.

I see.  Apologize for that and I will pay more attention next time when
handling cross-subsystem patches.
Mark Hasemeyer Jan. 9, 2023, 7:06 p.m. UTC | #9 
On Wed, Jan 4, 2023 at 9:08 AM Lee Jones <lee@kernel.org> wrote:
> I changed the subject line and applied the patch, thanks.

Hey Lee, a couple comments/questions:
1. The subject line of this patch was updated in v11 of the series.
2. What tree was the patch applied to? I don't see the changes in linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

On Thu, Jan 5, 2023 at 11:08 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Thu, Jan 05, 2023 at 04:27:32PM +0000, Lee Jones wrote:
> > > > You should gain permission from the maintainer before you apply patches.
> > > >
> > > >   % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > >      Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> > > >      Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > >      Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > >      Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> > >
> > > I see.  I guess for the case, I should get both MFD and DT bindings
> > > maintainers' Acks before applying the patch.
> >
> > Yes.  The situation isn't overly clear and differs from subsystem to
> > subsystem and maintainer to maintainer.  In the MFD case, Rob and
> > Krzysztof conduct the first reviews.  99 times out of 100, if they're
> > happy, I'm happy and I merge the changes via the MFD tree.  Same goes
> > for Backlight and more recently, LEDs.
>
> I see.  Apologize for that and I will pay more attention next time when
> handling cross-subsystem patches.
Lee Jones Jan. 10, 2023, 10:24 a.m. UTC | #10 
On Mon, 09 Jan 2023, Mark Hasemeyer wrote:

> On Wed, Jan 4, 2023 at 9:08 AM Lee Jones <lee@kernel.org> wrote:
> > I changed the subject line and applied the patch, thanks.
> 
> Hey Lee, a couple comments/questions:
> 1. The subject line of this patch was updated in v11 of the series.
> 2. What tree was the patch applied to? I don't see the changes in linux-next.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

Thanks for flagging.  You will do tomorrow.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 3d5efa5578d1b..cdf1d719efe9d 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -33,6 +33,9 @@  properties:
       - description:
           For implementations of the EC connected through RPMSG.
         const: google,cros-ec-rpmsg
+      - description:
+          For implementations of the EC connected through UART.
+        const: google,cros-ec-uart
 
   controller-data: true
 
@@ -187,6 +190,15 @@  allOf:
       properties:
         mediatek,rpmsg-name: false
 
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - google,cros-ec-rpmsg
+                - google,cros-ec-uart
+    then:
       required:
         - reg
         - interrupts
@@ -299,4 +311,12 @@  examples:
         vdd-supply = <&pp3300_fp_mcu>;
       };
     };
+
+  # Example for UART
+  - |
+    serial {
+        cros-ec {
+            compatible = "google,cros-ec-uart";
+        };
+    };
 ...