diff mbox series

platform: chrome: wilco_ec: remove return value check of debugfs_create_dir()

Message ID 20230419100303.343379-1-zkhuang@hust.edu.cn (mailing list archive)
State Accepted
Commit 0ad5ce8407db2e44922ee21d2f2a9de4df336038
Headers show
Series platform: chrome: wilco_ec: remove return value check of debugfs_create_dir() | expand

Commit Message

Zhengkang Huang April 19, 2023, 10:03 a.m. UTC 
Smatch complains that:
wilco_ec_debugfs_probe() warn: 'debug_info->dir' is an error 
pointer or valid 

Debugfs checks are generally not supposed to be checked 
for errors and it is not necessary here. 

Just delete the dead code. 

Signed-off-by: Zhengkang Huang <zkhuang@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
NOTES: The issue is found by static analysis and remains untested.
---

 drivers/platform/chrome/wilco_ec/debugfs.c | 2 --
 1 file changed, 2 deletions(-)

Comments

patchwork-bot+chrome-platform@kernel.org April 20, 2023, 1:50 a.m. UTC | #1 
Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 19 Apr 2023 18:03:03 +0800 you wrote:
> Smatch complains that:
> wilco_ec_debugfs_probe() warn: 'debug_info->dir' is an error
> pointer or valid
> 
> Debugfs checks are generally not supposed to be checked
> for errors and it is not necessary here.
> 
> [...]

Here is the summary with links:
  - platform: chrome: wilco_ec: remove return value check of debugfs_create_dir()
    https://git.kernel.org/chrome-platform/c/0ad5ce8407db

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org April 20, 2023, 4:10 a.m. UTC | #2 
Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Wed, 19 Apr 2023 18:03:03 +0800 you wrote:
> Smatch complains that:
> wilco_ec_debugfs_probe() warn: 'debug_info->dir' is an error
> pointer or valid
> 
> Debugfs checks are generally not supposed to be checked
> for errors and it is not necessary here.
> 
> [...]

Here is the summary with links:
  - platform: chrome: wilco_ec: remove return value check of debugfs_create_dir()
    https://git.kernel.org/chrome-platform/c/0ad5ce8407db

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c
index a812788a0bdc..7a13f13b16cd 100644
--- a/drivers/platform/chrome/wilco_ec/debugfs.c
+++ b/drivers/platform/chrome/wilco_ec/debugfs.c
@@ -251,8 +251,6 @@  static int wilco_ec_debugfs_probe(struct platform_device *pdev)
 		return 0;
 	debug_info->ec = ec;
 	debug_info->dir = debugfs_create_dir("wilco_ec", NULL);
-	if (!debug_info->dir)
-		return 0;
 	debugfs_create_file("raw", 0644, debug_info->dir, NULL, &fops_raw);
 	debugfs_create_file("h1_gpio", 0444, debug_info->dir, ec,
 			    &fops_h1_gpio);