From patchwork Wed Apr 19 10:03:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhengkang Huang X-Patchwork-Id: 13216603 Received: from hust.edu.cn (unknown [202.114.0.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C572F52 for ; Wed, 19 Apr 2023 10:02:21 +0000 (UTC) Received: from archlinux.localdomain ([10.12.190.56]) (user=zkhuang@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33JA1VTK021595-33JA1VTL021595 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 19 Apr 2023 18:01:36 +0800 From: Zhengkang Huang To: Benson Leung Cc: Zhengkang Huang , Dongliang Mu , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] platform: chrome: wilco_ec: remove return value check of debugfs_create_dir() Date: Wed, 19 Apr 2023 18:03:03 +0800 Message-Id: <20230419100303.343379-1-zkhuang@hust.edu.cn> X-Mailer: git-send-email 2.40.0 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-FEAS-AUTH-USER: zkhuang@hust.edu.cn Smatch complains that: wilco_ec_debugfs_probe() warn: 'debug_info->dir' is an error pointer or valid Debugfs checks are generally not supposed to be checked for errors and it is not necessary here. Just delete the dead code. Signed-off-by: Zhengkang Huang Reviewed-by: Dongliang Mu --- NOTES: The issue is found by static analysis and remains untested. --- drivers/platform/chrome/wilco_ec/debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c index a812788a0bdc..7a13f13b16cd 100644 --- a/drivers/platform/chrome/wilco_ec/debugfs.c +++ b/drivers/platform/chrome/wilco_ec/debugfs.c @@ -251,8 +251,6 @@ static int wilco_ec_debugfs_probe(struct platform_device *pdev) return 0; debug_info->ec = ec; debug_info->dir = debugfs_create_dir("wilco_ec", NULL); - if (!debug_info->dir) - return 0; debugfs_create_file("raw", 0644, debug_info->dir, NULL, &fops_raw); debugfs_create_file("h1_gpio", 0444, debug_info->dir, ec, &fops_h1_gpio);