| Message ID | 20230802175847.1.Ie9fc53b6a1f4c6661c5376286a50e0cf51b3e961@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f2d4dced9a584612b25adb559c1350243d2bb544 |
| Headers | show |
| Series | platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout | expand |
On Wed, Aug 2, 2023 at 10:59 AM Rob Barnes <robbarnes@google.com> wrote: > > Remove the 1 second timeout applied to hw_protection_shutdown after an > EC panic. On some platforms this 1 second timeout is insufficient to > allow the filesystem to fully sync. Independently the EC will force a > full system reset after a short period. So this backup timeout is > unnecessary. > > Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > > drivers/platform/chrome/cros_ec_lpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c > index 500a61b093e47..356572452898d 100644 > --- a/drivers/platform/chrome/cros_ec_lpc.c > +++ b/drivers/platform/chrome/cros_ec_lpc.c > @@ -327,8 +327,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data) > dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!"); > blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev); > kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env); > - /* Begin orderly shutdown. Force shutdown after 1 second. */ > - hw_protection_shutdown("CrOS EC Panic", 1000); > + /* Begin orderly shutdown. EC will force reset after a short period. */ > + hw_protection_shutdown("CrOS EC Panic", -1); > /* Do not query for other events after a panic is reported */ > return; > } > -- > 2.41.0.585.gd2178a4bd4-goog >
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Wed, 2 Aug 2023 17:58:48 +0000 you wrote: > Remove the 1 second timeout applied to hw_protection_shutdown after an > EC panic. On some platforms this 1 second timeout is insufficient to > allow the filesystem to fully sync. Independently the EC will force a > full system reset after a short period. So this backup timeout is > unnecessary. > > Signed-off-by: Rob Barnes <robbarnes@google.com> > > [...] Here is the summary with links: - platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout https://git.kernel.org/chrome-platform/c/f2d4dced9a58 You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <tzungbi@kernel.org>: On Wed, 2 Aug 2023 17:58:48 +0000 you wrote: > Remove the 1 second timeout applied to hw_protection_shutdown after an > EC panic. On some platforms this 1 second timeout is insufficient to > allow the filesystem to fully sync. Independently the EC will force a > full system reset after a short period. So this backup timeout is > unnecessary. > > Signed-off-by: Rob Barnes <robbarnes@google.com> > > [...] Here is the summary with links: - platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout https://git.kernel.org/chrome-platform/c/f2d4dced9a58 You are awesome, thank you!
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 500a61b093e47..356572452898d 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -327,8 +327,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data) dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!"); blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev); kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env); - /* Begin orderly shutdown. Force shutdown after 1 second. */ - hw_protection_shutdown("CrOS EC Panic", 1000); + /* Begin orderly shutdown. EC will force reset after a short period. */ + hw_protection_shutdown("CrOS EC Panic", -1); /* Do not query for other events after a panic is reported */ return; }
Remove the 1 second timeout applied to hw_protection_shutdown after an EC panic. On some platforms this 1 second timeout is insufficient to allow the filesystem to fully sync. Independently the EC will force a full system reset after a short period. So this backup timeout is unnecessary. Signed-off-by: Rob Barnes <robbarnes@google.com> --- drivers/platform/chrome/cros_ec_lpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)