| Message ID | 20240219202325.4095816-2-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7b79740d42e7535901296f7acbab1043633422e6 |
| Headers | show |
| Series | mfd: cros_ec_dev: Add gpio device and DT binding | expand |
On 19/02/2024 21:23, Stephen Boyd wrote: > The ChromeOS embedded controller (EC) supports setting the state of > GPIOs when the system is unlocked, and getting the state of GPIOs in all > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > expander. Add the #gpio-cells and gpio-controller properties to the > cros-ec binding so that other devices described in DT can get the GPIOs > on the EC. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Benson Leung <bleung@chromium.org> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: <devicetree@vger.kernel.org> > Cc: <chrome-platform@lists.linux.dev> > Cc: Pin-yen Lin <treapking@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Feb 19, 2024 at 9:23 PM Stephen Boyd <swboyd@chromium.org> wrote: > > The ChromeOS embedded controller (EC) supports setting the state of > GPIOs when the system is unlocked, and getting the state of GPIOs in all > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > expander. Add the #gpio-cells and gpio-controller properties to the > cros-ec binding so that other devices described in DT can get the GPIOs > on the EC. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Benson Leung <bleung@chromium.org> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: <devicetree@vger.kernel.org> > Cc: <chrome-platform@lists.linux.dev> > Cc: Pin-yen Lin <treapking@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index e1ca4f297c6d..aac8819bd00b 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -93,6 +93,11 @@ properties: > '#size-cells': > const: 0 > > + '#gpio-cells': > + const: 2 > + > + gpio-controller: true > + > typec: > $ref: /schemas/chrome/google,cros-ec-typec.yaml# > > @@ -275,6 +280,8 @@ examples: > interrupts = <99 0>; > interrupt-parent = <&gpio7>; > spi-max-frequency = <5000000>; > + #gpio-cells = <2>; > + gpio-controller; > > proximity { > compatible = "google,cros-ec-mkbp-proximity"; > -- > https://chromeos.dev > Applied, thanks! Bart
On Tue, 20 Feb 2024, Bartosz Golaszewski wrote: > On Mon, Feb 19, 2024 at 9:23 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > The ChromeOS embedded controller (EC) supports setting the state of > > GPIOs when the system is unlocked, and getting the state of GPIOs in all > > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > > expander. Add the #gpio-cells and gpio-controller properties to the > > cros-ec binding so that other devices described in DT can get the GPIOs > > on the EC. > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > Cc: Conor Dooley <conor+dt@kernel.org> > > Cc: Lee Jones <lee@kernel.org> > > Cc: Benson Leung <bleung@chromium.org> > > Cc: Guenter Roeck <groeck@chromium.org> > > Cc: <devicetree@vger.kernel.org> > > Cc: <chrome-platform@lists.linux.dev> > > Cc: Pin-yen Lin <treapking@chromium.org> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > --- > > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index e1ca4f297c6d..aac8819bd00b 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -93,6 +93,11 @@ properties: > > '#size-cells': > > const: 0 > > > > + '#gpio-cells': > > + const: 2 > > + > > + gpio-controller: true > > + > > typec: > > $ref: /schemas/chrome/google,cros-ec-typec.yaml# > > > > @@ -275,6 +280,8 @@ examples: > > interrupts = <99 0>; > > interrupt-parent = <&gpio7>; > > spi-max-frequency = <5000000>; > > + #gpio-cells = <2>; > > + gpio-controller; > > > > proximity { > > compatible = "google,cros-ec-mkbp-proximity"; > > -- > > https://chromeos.dev > > > > Applied, thanks! Why are you applying this MFD patch?
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index e1ca4f297c6d..aac8819bd00b 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -93,6 +93,11 @@ properties: '#size-cells': const: 0 + '#gpio-cells': + const: 2 + + gpio-controller: true + typec: $ref: /schemas/chrome/google,cros-ec-typec.yaml# @@ -275,6 +280,8 @@ examples: interrupts = <99 0>; interrupt-parent = <&gpio7>; spi-max-frequency = <5000000>; + #gpio-cells = <2>; + gpio-controller; proximity { compatible = "google,cros-ec-mkbp-proximity";
The ChromeOS embedded controller (EC) supports setting the state of GPIOs when the system is unlocked, and getting the state of GPIOs in all cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO expander. Add the #gpio-cells and gpio-controller properties to the cros-ec binding so that other devices described in DT can get the GPIOs on the EC. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Lee Jones <lee@kernel.org> Cc: Benson Leung <bleung@chromium.org> Cc: Guenter Roeck <groeck@chromium.org> Cc: <devicetree@vger.kernel.org> Cc: <chrome-platform@lists.linux.dev> Cc: Pin-yen Lin <treapking@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 7 +++++++ 1 file changed, 7 insertions(+)