| Message ID | 20240314052828.186924-1-aichao@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f7496450528bfe9350c5a62d180b4926b96f571b |
| Headers | show |
| Series | [v1] platform/chrome: use sysfs_emit() instead of sprintf() | expand |
On Thu, Mar 14, 2024 at 01:28:28PM +0800, Ai Chao wrote: > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. It seems we overlooked the case when handling [1]. Will queue the patch after for-next rebased to next -rc1. [1] https://patchwork.kernel.org/project/chrome-platform/patch/202212021656040995199@zte.com.cn/
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Thu, 14 Mar 2024 13:28:28 +0800 you wrote: > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. > > Signed-off-by: Ai Chao <aichao@kylinos.cn> > --- > drivers/platform/chrome/wilco_ec/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [v1] platform/chrome: use sysfs_emit() instead of sprintf() https://git.kernel.org/chrome-platform/c/f7496450528b You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <tzungbi@kernel.org>: On Thu, 14 Mar 2024 13:28:28 +0800 you wrote: > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. > > Signed-off-by: Ai Chao <aichao@kylinos.cn> > --- > drivers/platform/chrome/wilco_ec/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [v1] platform/chrome: use sysfs_emit() instead of sprintf() https://git.kernel.org/chrome-platform/c/f7496450528b You are awesome, thank you!
diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c index 893c59dde32a..d44c43559621 100644 --- a/drivers/platform/chrome/wilco_ec/sysfs.c +++ b/drivers/platform/chrome/wilco_ec/sysfs.c @@ -192,7 +192,7 @@ static ssize_t usb_charge_show(struct device *dev, if (ret < 0) return ret; - return sprintf(buf, "%d\n", rs.val); + return sysfs_emit(buf, "%d\n", rs.val); } static ssize_t usb_charge_store(struct device *dev,
Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Ai Chao <aichao@kylinos.cn> --- drivers/platform/chrome/wilco_ec/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)