| Message ID | 20240329075630.2069474-16-tzungbi@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b17dd111645bc07acdaff88b2e6aa025ae9e3581 |
| Headers | show |
| Series | platform/chrome: provide ID table for avoiding fallback match | expand |
On 29/03/2024 08:56, Tzung-Bi Shih wrote: > Instead of using fallback driver name match, provide ID table[1] for the > primary match. > > [1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c#L1353 > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Mar 29, 2024 at 03:56:27PM +0800, Tzung-Bi Shih wrote: > Instead of using fallback driver name match, provide ID table[1] for the > primary match. > > [1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c#L1353 > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/platform/chrome/wilco_ec/telemetry.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c > index b7c616f3d179..21d4cbbb009a 100644 > --- a/drivers/platform/chrome/wilco_ec/telemetry.c > +++ b/drivers/platform/chrome/wilco_ec/telemetry.c > @@ -30,6 +30,7 @@ > #include <linux/cdev.h> > #include <linux/device.h> > #include <linux/fs.h> > +#include <linux/mod_devicetable.h> > #include <linux/module.h> > #include <linux/platform_data/wilco-ec.h> > #include <linux/platform_device.h> > @@ -409,12 +410,19 @@ static void telem_device_remove(struct platform_device *pdev) > put_device(&dev_data->dev); > } > > +static const struct platform_device_id telem_id[] = { > + { DRV_NAME, 0 }, > + {} > +}; > +MODULE_DEVICE_TABLE(platform, telem_id); > + > static struct platform_driver telem_driver = { > .probe = telem_device_probe, > .remove_new = telem_device_remove, > .driver = { > .name = DRV_NAME, > }, > + .id_table = telem_id, > }; > > static int __init telem_module_init(void) > @@ -466,4 +474,3 @@ module_exit(telem_module_exit); > MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); > MODULE_DESCRIPTION("Wilco EC telemetry driver"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:" DRV_NAME); > -- > 2.44.0.478.gd926399ef9-goog > >
diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c index b7c616f3d179..21d4cbbb009a 100644 --- a/drivers/platform/chrome/wilco_ec/telemetry.c +++ b/drivers/platform/chrome/wilco_ec/telemetry.c @@ -30,6 +30,7 @@ #include <linux/cdev.h> #include <linux/device.h> #include <linux/fs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_data/wilco-ec.h> #include <linux/platform_device.h> @@ -409,12 +410,19 @@ static void telem_device_remove(struct platform_device *pdev) put_device(&dev_data->dev); } +static const struct platform_device_id telem_id[] = { + { DRV_NAME, 0 }, + {} +}; +MODULE_DEVICE_TABLE(platform, telem_id); + static struct platform_driver telem_driver = { .probe = telem_device_probe, .remove_new = telem_device_remove, .driver = { .name = DRV_NAME, }, + .id_table = telem_id, }; static int __init telem_module_init(void) @@ -466,4 +474,3 @@ module_exit(telem_module_exit); MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); MODULE_DESCRIPTION("Wilco EC telemetry driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRV_NAME);
Instead of using fallback driver name match, provide ID table[1] for the primary match. [1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c#L1353 Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> --- drivers/platform/chrome/wilco_ec/telemetry.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)