diff mbox series

platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*

Message ID 20240430020924.610724-1-tzungbi@kernel.org (mailing list archive)
State Accepted
Commit 47ef58cdbd7fae42f1adcb6015fdc05ce2b2471e
Headers show
Series platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_* | expand

Commit Message

Tzung-Bi Shih April 30, 2024, 2:09 a.m. UTC
After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
during suspend after resume completion"), cros_ec_resume() starts to
call cros_ec_resume_early() and cros_ec_resume_complete().

To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
cros_ec_suspend_late().

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
 drivers/platform/chrome/cros_ec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Prashant Malani May 14, 2024, 7:47 p.m. UTC | #1
On Mon, Apr 29, 2024 at 7:09 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
>
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
patchwork-bot+chrome-platform@kernel.org May 27, 2024, 3:10 a.m. UTC | #2
Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Tue, 30 Apr 2024 10:09:24 +0800 you wrote:
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
> 
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
    https://git.kernel.org/chrome-platform/c/47ef58cdbd7f

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org May 27, 2024, 3:10 a.m. UTC | #3
Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Tue, 30 Apr 2024 10:09:24 +0800 you wrote:
> After commit 2fbe479c0024 ("platform/chrome: cros_ec: Handle events
> during suspend after resume completion"), cros_ec_resume() starts to
> call cros_ec_resume_early() and cros_ec_resume_complete().
> 
> To be neat, let cros_ec_suspend() call cros_ec_suspend_prepare() and
> cros_ec_suspend_late().
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_ec: let cros_ec_suspend() call cros_ec_suspend_*
    https://git.kernel.org/chrome-platform/c/47ef58cdbd7f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 47d19f7e295a..e821b3d39590 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -388,8 +388,8 @@  EXPORT_SYMBOL(cros_ec_suspend_late);
  */
 int cros_ec_suspend(struct cros_ec_device *ec_dev)
 {
-	cros_ec_send_suspend_event(ec_dev);
-	cros_ec_disable_irq(ec_dev);
+	cros_ec_suspend_prepare(ec_dev);
+	cros_ec_suspend_late(ec_dev);
 	return 0;
 }
 EXPORT_SYMBOL(cros_ec_suspend);