From patchwork Mon May 20 10:00:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 13668160 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCEF42044 for ; Mon, 20 May 2024 10:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716199277; cv=none; b=isxr5dXi4iI3XOe7x+TFdDQJEoMPInGWUIRMye8GAj1rEjqdWuhCMuqx5T7ch6LbFLTc6SpG2qK2LqFlRScRhJpUJ56NzkbKkfAvTBykxPAAHTTurmdZhUQrOMxTpoqIXPrTwG5yCmfoANMhmoSXQJ7GNCM1eit/3HqKhOtZaUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716199277; c=relaxed/simple; bh=BcMXMIsO1+Tp961ErDaYIMw6fdjqO2GgDS3upFE+hj8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MaNtBH+WeCL2orQHmGDQJH4DYQGIwUN3PrFurETixCbHhE0yp/Z32vXQ/xjN5rR+QDaz8qtWrPgGU6mopJl0l90tPk535lo9FaM/FWD35g9e4YB16sThSQooLoB+n2CaEClHDUuhDipYIfCUnzDDCpuRck1KPSOYs7l4rU+UEuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=WhmDdrhW; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="WhmDdrhW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1716199266; bh=BcMXMIsO1+Tp961ErDaYIMw6fdjqO2GgDS3upFE+hj8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WhmDdrhWo33Rk9k9SHe0ItXblVL/obibAghcLq6Jxrh4td6V2BufSDcoqgunLS5Vr KRyQmaqlR/DVBBdYK+N3wJL6M2NLEaNl2JQnqneWI1uRPQF55X+W2A20cCaKVxRX4+ l8iq+tUXvFfvj8X0gD02IDcUYYM851u2T66Td75k= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Mon, 20 May 2024 12:00:30 +0200 Subject: [PATCH 2/5] leds: multicolor: use led_color_name function Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240520-cros_ec-led-v1-2-4068fc5c051a@weissschuh.net> References: <20240520-cros_ec-led-v1-0-4068fc5c051a@weissschuh.net> In-Reply-To: <20240520-cros_ec-led-v1-0-4068fc5c051a@weissschuh.net> To: Pavel Machek , Lee Jones , =?utf-8?q?Thoma?= =?utf-8?q?s_Wei=C3=9Fschuh?= , Benson Leung , Guenter Roeck Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Dustin Howett , Mario Limonciello , =?utf-8?q?Thomas_Wei=C3=9Fs?= =?utf-8?q?chuh?= X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1716199265; l=937; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=BcMXMIsO1+Tp961ErDaYIMw6fdjqO2GgDS3upFE+hj8=; b=xq/8FXBPWAH0B005k6cY7z5AwjTdngxVumJMnJdYq4wbjq0eZI3W0MekS3WW4KST81Fd8yCjB 45kT8sgA9JaCJaagWlzyBCFzBe2keaWExFCDBkiqCcQ6XX33IxYIp76 X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= led_color_name is a safer alternative to led_colors. led-class-multicolor.c is the only external user of led_colors and its removal allows the unexporting of the array. Signed-off-by: Thomas Weißschuh --- drivers/leds/led-class-multicolor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c index ec62a4811613..34bdebcf239e 100644 --- a/drivers/leds/led-class-multicolor.c +++ b/drivers/leds/led-class-multicolor.c @@ -101,7 +101,7 @@ static ssize_t multi_index_show(struct device *dev, for (i = 0; i < mcled_cdev->num_colors; i++) { index = mcled_cdev->subled_info[i].color_index; - len += sprintf(buf + len, "%s", led_colors[index]); + len += sprintf(buf + len, "%s", led_color_name(index)); if (i < mcled_cdev->num_colors - 1) len += sprintf(buf + len, " "); }