| Message ID | 20240613212542.403-1-ben@jubnut.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b57cd5703a1618e87772094ac12c5ee7d6c35e2f |
| Headers | show |
| Series | platform/chrome: cros_ec_lpc: Handle zero length read/write | expand |
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <tzungbi@kernel.org>: On Thu, 13 Jun 2024 22:25:42 +0100 you wrote: > cros_ec_lpc_mec_read_bytes and cros_ec_lpc_mec_write_bytes call > cros_ec_lpc_mec_in_range, which checks if addresses are in the MEC > address range, and returns -EINVAL if the range given is not sensible. > > However cros_ec_lpc_mec_in_range was also returning -EINVAL for a zero > length range. > > [...] Here is the summary with links: - platform/chrome: cros_ec_lpc: Handle zero length read/write https://git.kernel.org/chrome-platform/c/b57cd5703a16 You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <tzungbi@kernel.org>: On Thu, 13 Jun 2024 22:25:42 +0100 you wrote: > cros_ec_lpc_mec_read_bytes and cros_ec_lpc_mec_write_bytes call > cros_ec_lpc_mec_in_range, which checks if addresses are in the MEC > address range, and returns -EINVAL if the range given is not sensible. > > However cros_ec_lpc_mec_in_range was also returning -EINVAL for a zero > length range. > > [...] Here is the summary with links: - platform/chrome: cros_ec_lpc: Handle zero length read/write https://git.kernel.org/chrome-platform/c/b57cd5703a16 You are awesome, thank you!
On Thu, Jun 13, 2024 at 10:25:42PM +0100, Ben Walsh wrote: > cros_ec_lpc_mec_read_bytes and cros_ec_lpc_mec_write_bytes call > cros_ec_lpc_mec_in_range, which checks if addresses are in the MEC > address range, and returns -EINVAL if the range given is not sensible. > > However cros_ec_lpc_mec_in_range was also returning -EINVAL for a zero > length range. > > A zero length range should not be an error condition. > cros_ec_lpc_mec_in_range now returns 1 in this case. > cros_ec_lpc_io_bytes_mec checks for zero length, and returns > immediately without beginning a transfer. > > Signed-off-by: Ben Walsh <ben@jubnut.com> Ideally this would have a Fixes tag that points to my commit. regards, dan carpenter
diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c index dfad934e65ca..a56584171168 100644 --- a/drivers/platform/chrome/cros_ec_lpc_mec.c +++ b/drivers/platform/chrome/cros_ec_lpc_mec.c @@ -93,9 +93,6 @@ static void cros_ec_lpc_mec_emi_write_address(u16 addr, */ int cros_ec_lpc_mec_in_range(unsigned int offset, unsigned int length) { - if (length == 0) - return -EINVAL; - if (WARN_ON(mec_emi_base == 0 || mec_emi_end == 0)) return -EINVAL; @@ -132,6 +129,9 @@ int cros_ec_lpc_io_bytes_mec(enum cros_ec_lpc_mec_io_type io_type, enum cros_ec_lpc_mec_emi_access_mode access, new_access; int ret; + if (length == 0) + return 0; + /* Return checksum of 0 if window is not initialized */ WARN_ON(mec_emi_base == 0 || mec_emi_end == 0); if (mec_emi_base == 0 || mec_emi_end == 0)
cros_ec_lpc_mec_read_bytes and cros_ec_lpc_mec_write_bytes call cros_ec_lpc_mec_in_range, which checks if addresses are in the MEC address range, and returns -EINVAL if the range given is not sensible. However cros_ec_lpc_mec_in_range was also returning -EINVAL for a zero length range. A zero length range should not be an error condition. cros_ec_lpc_mec_in_range now returns 1 in this case. cros_ec_lpc_io_bytes_mec checks for zero length, and returns immediately without beginning a transfer. Signed-off-by: Ben Walsh <ben@jubnut.com> --- drivers/platform/chrome/cros_ec_lpc_mec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 77a714325d09e1527d865dc011ef91c4972ffedd