| Message ID | 20250113-hw_protection-reboot-v2-12-161d3fc734f0@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | reboot: support runtime configuration of emergency hw_protection action | expand |
On Mon, Jan 13, 2025 at 05:25:37PM +0100, Ahmad Fatoum wrote: > The hw_protection_reboot and hw_protection_shutdown functions mix > mechanism with policy: They let the driver requesting an emergency > action for hardware protection also decide how to deal with it. > > This is inadequate in the general case as a driver reporting e.g. an > imminent power failure can't know whether a shutdown or a reboot would > be more appropriate for a given hardware platform. > > With the addition of the hw_protection parameter, it's now possible to > configure at runtime the default emergency action and drivers are > expected to use hw_protection_trigger to have this parameter dictate > policy. > > As no current users of either hw_protection_shutdown or > hw_protection_shutdown helpers remain, remove them, as not to tempt > driver authors to call them. > > Existing users now either defer to hw_protection_trigger or call > __hw_protection_trigger with a suitable argument directly when > they have inside knowledge on whether a reboot or shutdown would > be more appropriate. > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
diff --git a/include/linux/reboot.h b/include/linux/reboot.h index 79e02876f2ba2b5508f6f26567cbcd5cbe97a277..aa08c3bbbf59a9dec65d775d280902b1455427c2 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -211,16 +211,6 @@ static inline void hw_protection_trigger(const char *reason, int ms_until_forced __hw_protection_trigger(reason, ms_until_forced, HWPROT_ACT_DEFAULT); } -static inline void hw_protection_reboot(const char *reason, int ms_until_forced) -{ - __hw_protection_trigger(reason, ms_until_forced, HWPROT_ACT_REBOOT); -} - -static inline void hw_protection_shutdown(const char *reason, int ms_until_forced) -{ - __hw_protection_trigger(reason, ms_until_forced, HWPROT_ACT_SHUTDOWN); -} - /* * Emergency restart, callable from an interrupt handler. */
The hw_protection_reboot and hw_protection_shutdown functions mix mechanism with policy: They let the driver requesting an emergency action for hardware protection also decide how to deal with it. This is inadequate in the general case as a driver reporting e.g. an imminent power failure can't know whether a shutdown or a reboot would be more appropriate for a given hardware platform. With the addition of the hw_protection parameter, it's now possible to configure at runtime the default emergency action and drivers are expected to use hw_protection_trigger to have this parameter dictate policy. As no current users of either hw_protection_shutdown or hw_protection_shutdown helpers remain, remove them, as not to tempt driver authors to call them. Existing users now either defer to hw_protection_trigger or call __hw_protection_trigger with a suitable argument directly when they have inside knowledge on whether a reboot or shutdown would be more appropriate. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- include/linux/reboot.h | 10 ---------- 1 file changed, 10 deletions(-)