From patchwork Mon Mar 10 12:40:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14009916 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A197B225416 for ; Mon, 10 Mar 2025 12:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741610432; cv=none; b=MqCBOyQ+U8qoD/Vl9Eq605MtBt/mv1Uon89O1Gtgr+G/ul3nUHbGTmlLnnkdVJjeJgTTSu+0uwRfIZcx3b7a7K37GgZBOpXRpK8kHm5lbqMSPRA6VFCXonXj9LCAYn6lZgtJseLUKNokTiNBkoWeYdCTo8Sj7MuGBtzWTsHxnrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741610432; c=relaxed/simple; bh=bI6mG7/fE9jq7Qq8jr8Olj76OfGfb5CZqhqJYkdpgIQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CvMIocL9FB55kr+X4zDs5ZYXqX7A2HI6wjBrIDyhlmiH1oCF8UsKGNs7rpWmgPxPcJfXJbVAa/CmAPyiSfeKzQx2ozKGholgI2zaeUh1F/NA5fL2UI3hEAx3btCdm/mWWqEuL7skX4Pe04jNmv6lw90uNunOsIP16L80A3Uhh/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qvSWPNmL; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qvSWPNmL" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3913cf69784so2090160f8f.1 for ; Mon, 10 Mar 2025 05:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1741610428; x=1742215228; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/L0SErO8WvvIla0Y0YBFAJJ/7qX89FBxAZLtN/OcJaE=; b=qvSWPNmLBanIA5R6ogRgHGO5zGWSw6pQxGo12Nl80pvZe+cOkkGuNkdcVSIfFjThbi uhfCnGFRjktRMoaElutP9gHxD0MO09VhAxKCNpXdaqTdlx34dHunYvUPp2gAUPhQujdj xwdHvWupnGjD+behQqmvtcMwpKSSd1DgFCO0qjSwiXelZO1w43YtFW77Mx5R+VjMTOcn 1bbz8jGYZhDeyTN+KI/OrpJM0Xfag7Yq8KLs9DVCv7t2Mltq4VhshHk887MKnAl7ZH1r V8EqonnYpbWpfvh1wnnyONyoLdOneKlQ7xDKtYCslyngPIJ19NTtQ/Gg+1UnaNlAMwKX f//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741610428; x=1742215228; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/L0SErO8WvvIla0Y0YBFAJJ/7qX89FBxAZLtN/OcJaE=; b=r+v0ZeG/JDWtQ48XZ17mN3DQC+xr0W7aAN7bB+2bIeZnzLkeD4vJjwXDQem2hcUgB3 IFwk5Bm+OlKBQyK9MRBG6pt96sr5a85WpnxZ4rY1ZtNJYYO8ViD5+rLX8TEylpJuS3iV vQeBLMAKR35Bni8s3BDLjKzmfJP1nQU6s7T0rWVEMPMbRlQUWOOMn1sCpTXMmhJ+8aeM 2o4O7oLF49ST8VqQ4OQOAvX/GOujLozHmKs8T86M/30TwRsXnI9s8JZGLmSiSWWScOxx ylWRZl6yGZ5jnDN7k/9aYNBqrKMs7drsAmgWYxTeZN4izjKRe+qLDF3qjIB7W2eFywmT PeQQ== X-Forwarded-Encrypted: i=1; AJvYcCWdxZerMcPPuhQw1LExB1GrK3o6cL/cF1TxojK25NVUlGq8ECj1DNYMfCkkOMWMEglwjiKBdrpEDUzyK16G5U0=@lists.linux.dev X-Gm-Message-State: AOJu0YwKVgUSN5kkpHZJTAo8sZSBa3PCLPRHmclh9UHrwUC4OBmAdC0v R5g2vv5u3MYjX1qqsktNXGBnCFTS2VX5Gy6RkSXMc2YLSf9HEPYnqOq1uV6uWzo= X-Gm-Gg: ASbGncvRoEKwvXeFZEUmdkzXZteYuR90ya4w3Tsb0cstbEQOZPDBuCNiYP3PfwgQgrG 32A1edWGhZJ95Ne/J4hyngQ0DKAbwdJBwhIZ4cCLA8U3oER9VwWixVgdBUr+GBI/rucUPmQpaUQ S9H7A88hTRU9FiLXFXeqh0IYlR/TgSj7yBT2fNO3l6h6yZMxF/ICbjGBKa06T+APrCJqygGyHwy 8x2zKGu7wwo7wfpUCm2lsbmiiDgLhD11by0hMFz2D9K/DqhOjtpCvbOPgFNad37g5CyKvILcGpp bewqUFidNRLbhBGA+csSHLMk46Tsq5BNe+34XA== X-Google-Smtp-Source: AGHT+IEnaw7V2VP+vh9JbbBGJEoMvc9VnDBShuCZR28K0t7oQnFw+oD6yp2XEyGkyhvpHF2Q74qQhg== X-Received: by 2002:a05:6000:1786:b0:391:4940:45c3 with SMTP id ffacd0b85a97d-39149404778mr2988461f8f.54.1741610427788; Mon, 10 Mar 2025 05:40:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2711:39c0:fb51:b639]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfdc5sm14535865f8f.25.2025.03.10.05.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:40:27 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 10 Mar 2025 13:40:16 +0100 Subject: [PATCH 02/15] gpio: bcm-kona: use new line value setter callbacks Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-gpiochip-set-conversion-v1-2-03798bb833eb@linaro.org> References: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> In-Reply-To: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> To: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Scott Branden , Matti Vaittinen , Marek Vasut , Michael Buesch , Thomas Richard , Eugeniy Paltsev , Benson Leung , Guenter Roeck , Andy Shevchenko , Support Opensource Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chrome-platform@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ena6WHE884GsVxxatzXeIBrVJoOFvrALfVCBpMq4+UM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnzt21X4gVG0AtYLf8B34gfdK26s44k/mluoSJR blcmhmybxWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ87dtQAKCRARpy6gFHHX coauD/42zIRwrSrdastPpJO1Hv/NxiYRzjpa9b3Ox8STZOgaNunOonmOQFdcp//MpXn5/aNph5e veWkwQiYE1YuqCZl4nvbppnQM063SGSB7MFg82Es+DJ9CtS4v+RLlnzGgoVmkgWLFI5122W1q4X WrJtp7NzIjqbRIgx+meu5Ai91eHLAScqBMSp3WPL0nkSNYHDrXqJEYEW+dDm60EotES7PZpw5qw qfDb3I1iez6N3IHHfacjuHNdjAQEm/ZX7pxBsaLnrKLN1UJgeEdKFEQSwk0mBD9B4NDrxwKZEHl K1J3VCVEP0VBwmDWn5msWrNJ8vjv7zQ/sFLWxE97DyRbEDF5fDo8QD/XOaA4/XUJf1tbcoKMp69 wRggj88FDQxA68q+4a3xXmW7V47tmZCezT0rSIwkWjbwtJige0rPXSnyczrfMtF946zGpKemP3D qFxk/InIE9k9+vLkj6p0oV+KPU07sOmRuCuthg4oQyZAnKafe+1PzZkWXr7h6zUwmS2N7pHwgkt 4ZEfM1cK4RRM5JYnqyCgb28eKAMcJ/6ZbVTM3RJaw1g2uf1rPv438xrWT6GvA3ss11WYH06+xpP Pe6yB5govorUQ1JZHwcugOcqeGQ14qkm6rzKdeVBNQ0jh/ItcNY4i0THjySBTO1t5ApdVHA73dZ 6bRvQwflztwfyrQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-bcm-kona.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index a7390b1f1173..17c287dc7471 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -149,7 +149,8 @@ static int bcm_kona_gpio_get_dir(struct gpio_chip *chip, unsigned gpio) return val ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; } -static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) +static int bcm_kona_gpio_set(struct gpio_chip *chip, unsigned int gpio, + int value) { struct bcm_kona_gpio *kona_gpio; void __iomem *reg_base; @@ -164,13 +165,15 @@ static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) /* this function only applies to output pin */ if (bcm_kona_gpio_get_dir(chip, gpio) == GPIO_LINE_DIRECTION_IN) - return; + return 0; reg_offset = value ? GPIO_OUT_SET(bank_id) : GPIO_OUT_CLEAR(bank_id); val = readl(reg_base + reg_offset); val |= BIT(bit); writel(val, reg_base + reg_offset); + + return 0; } static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio) @@ -336,7 +339,7 @@ static const struct gpio_chip template_chip = { .direction_input = bcm_kona_gpio_direction_input, .get = bcm_kona_gpio_get, .direction_output = bcm_kona_gpio_direction_output, - .set = bcm_kona_gpio_set, + .set_rv = bcm_kona_gpio_set, .set_config = bcm_kona_gpio_set_config, .to_irq = bcm_kona_gpio_to_irq, .base = 0,