mbox series

[v3,0/7] DFS fixes

Message ID 20200721123644.14728-1-pc@cjr.nz
Headers show
Series DFS fixes | expand

Message

Paulo Alcantara July 21, 2020, 12:36 p.m. UTC
Hi Steve,

Follow some fixes, cleanups and documentation for DFS.

All DFS failover tests passed with this series in our local buildbot.

v1 -> v2:
  * fix bad rebase that removed usage of "share_len" in scnprintf()
    (Metze)

v2 -> v3:
  * fix typo and bad comment style in patch 7/7 (Aurelien)

Paulo Alcantara (6):
  cifs: reduce number of referral requests in DFS link lookups
  cifs: rename reconn_inval_dfs_target()
  cifs: handle empty list of targets in cifs_reconnect()
  cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect
  cifs: only update prefix path of DFS links in cifs_tree_connect()
  cifs: document and cleanup dfs mount

Stefan Metzmacher (1):
  cifs: merge __{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect()

 fs/cifs/cifsproto.h |   6 +-
 fs/cifs/cifssmb.c   | 112 +---------
 fs/cifs/connect.c   | 505 ++++++++++++++++++++++++++------------------
 fs/cifs/dfs_cache.c | 136 +++++++++---
 fs/cifs/dfs_cache.h |   7 +-
 fs/cifs/misc.c      |   7 +-
 fs/cifs/smb2pdu.c   | 113 +---------
 7 files changed, 429 insertions(+), 457 deletions(-)

Comments

Aurélien Aptel July 30, 2020, 12:16 p.m. UTC | #1
I'm not sure I fully understand what is going on in patch 6 & 7 but we
have tested this locally and seems to work properly. These changes make
edge cases DFS link targets work, fixes reconnection/failover where
there are mixups between netbios/fqdn host from mount call or link
targets, and other things (null ptr deref?).

So AFAIC you can merge with

Reviewed-by: Aurelien Aptel <aaptel@suse.com>

Cheers,
Steve French July 30, 2020, 9:34 p.m. UTC | #2
First five of these seven now tentatively merged into cifs-2.6.git
for-next pending more testing

(waiting on a little more review feedback on last two ... or time to
look in more detail)

On Thu, Jul 30, 2020 at 7:16 AM Aurélien Aptel <aaptel@suse.com> wrote:
>
> I'm not sure I fully understand what is going on in patch 6 & 7 but we
> have tested this locally and seems to work properly. These changes make
> edge cases DFS link targets work, fixes reconnection/failover where
> there are mixups between netbios/fqdn host from mount call or link
> targets, and other things (null ptr deref?).
>
> So AFAIC you can merge with
>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)