mbox series

[v2,0/2] Fix some bug in cifs

Message ID 20221116031136.3967579-1-zhangxiaoxu5@huawei.com (mailing list archive)
Headers show
Series Fix some bug in cifs | expand

Message

Zhang Xiaoxu Nov. 16, 2022, 3:11 a.m. UTC
v2: 
  - remove the 1st patch since steve already merged it into repo.
  - fix cifs 1.0 hung since not set READY flag when wakeup task 
    on 2nd patch.

Zhang Xiaoxu (2):
  cifs: Fix UAF in cifs_demultiplex_thread()
  cifs: Move the in_send statistic to __smb_send_rqst()

 fs/cifs/cifsglob.h  |  1 +
 fs/cifs/transport.c | 55 ++++++++++++++++++++++++++-------------------
 2 files changed, 33 insertions(+), 23 deletions(-)

Comments

ChenXiaoSong March 3, 2023, 2:02 a.m. UTC | #1
Hi Steve and Paulo:

Do you have any suggestions for this patchset ?

xfstests generic/011 always report this bug, our mount option is: -o 
mfsymlinks,vers=3.0

在 2022/11/16 11:11, Zhang Xiaoxu 写道:
> v2:
>    - remove the 1st patch since steve already merged it into repo.
>    - fix cifs 1.0 hung since not set READY flag when wakeup task
>      on 2nd patch.
> 
> Zhang Xiaoxu (2):
>    cifs: Fix UAF in cifs_demultiplex_thread()
>    cifs: Move the in_send statistic to __smb_send_rqst()
> 
>   fs/cifs/cifsglob.h  |  1 +
>   fs/cifs/transport.c | 55 ++++++++++++++++++++++++++-------------------
>   2 files changed, 33 insertions(+), 23 deletions(-)
>
Paulo Alcantara March 3, 2023, 9:55 p.m. UTC | #2
ChenXiaoSong <chenxiaosong2@huawei.com> writes:

> Do you have any suggestions for this patchset ?

Nope.  LGTM.

I was able to reproduce this use-after-free bug as well.

So, for the whole series

Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>