mbox series

[0/3] cifs: Cleanup of duplicated structures

Message ID 20241222172404.24755-1-pali@kernel.org (mailing list archive)
Headers show
Series cifs: Cleanup of duplicated structures | expand

Message

Pali Rohár Dec. 22, 2024, 5:24 p.m. UTC 
This patch series contains only code cleanup of few duplicates structures
and enums between smb/common and smb/client subdirs. No function change.

Can be useful also for ksmbd server part.

Pali Rohár (3):
  cifs: Remove struct reparse_posix_data from struct cifs_open_info_data
  cifs: Remove duplicate struct reparse_symlink_data and
    SYMLINK_FLAG_RELATIVE
  cifs: Rename struct reparse_posix_data to reparse_nfs_data_buffer and
    move to common/smb2pdu.h

 fs/smb/client/cifsglob.h |  5 +----
 fs/smb/client/cifspdu.h  | 30 ------------------------------
 fs/smb/client/reparse.c  | 15 +++++++--------
 fs/smb/common/smb2pdu.h  | 14 +++++++++++++-
 4 files changed, 21 insertions(+), 43 deletions(-)

Comments

Namjae Jeon Dec. 24, 2024, 7:38 a.m. UTC | #1 
On Mon, Dec 23, 2024 at 2:24 AM Pali Rohár <pali@kernel.org> wrote:
>
> This patch series contains only code cleanup of few duplicates structures
> and enums between smb/common and smb/client subdirs. No function change.
>
> Can be useful also for ksmbd server part.
>
> Pali Rohár (3):
>   cifs: Remove struct reparse_posix_data from struct cifs_open_info_data
>   cifs: Remove duplicate struct reparse_symlink_data and
>     SYMLINK_FLAG_RELATIVE
>   cifs: Rename struct reparse_posix_data to reparse_nfs_data_buffer and
>     move to common/smb2pdu.h
Looks good to me:)
Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks!
>
>  fs/smb/client/cifsglob.h |  5 +----
>  fs/smb/client/cifspdu.h  | 30 ------------------------------
>  fs/smb/client/reparse.c  | 15 +++++++--------
>  fs/smb/common/smb2pdu.h  | 14 +++++++++++++-
>  4 files changed, 21 insertions(+), 43 deletions(-)
>
> --
> 2.20.1
>