mbox series

[0/2] cifs: fix integer overflow in match_server()

Message ID 20250331082251.123381-1-r.smirnov@omp.ru (mailing list archive)
Headers show
Series cifs: fix integer overflow in match_server() | expand

Message

Roman Smirnov March 31, 2025, 8:22 a.m. UTC 
If a large number is written to echo_interval during mount,
an integer overflow may occur in match_server():

smb3_fs_context_parse_param()

cifs_smb3_do_mount()
  sget()
    cifs_match_super()
      match_server()

Found by Linux Verification Center (linuxtesting.org) with Svace.

Roman Smirnov (2):
  cifs: fix integer overflow in match_server()
  cifs: remove unreachable code in cifs_get_tcp_session()

 fs/smb/client/connect.c    | 6 +-----
 fs/smb/client/fs_context.c | 5 +++++
 2 files changed, 6 insertions(+), 5 deletions(-)

Comments

Steve French March 31, 2025, 10:48 p.m. UTC | #1 
Merged into cifs-2.6.git for-next

On Mon, Mar 31, 2025 at 3:23 AM Roman Smirnov <r.smirnov@omp.ru> wrote:
>
> If a large number is written to echo_interval during mount,
> an integer overflow may occur in match_server():
>
> smb3_fs_context_parse_param()
>
> cifs_smb3_do_mount()
>   sget()
>     cifs_match_super()
>       match_server()
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Roman Smirnov (2):
>   cifs: fix integer overflow in match_server()
>   cifs: remove unreachable code in cifs_get_tcp_session()
>
>  fs/smb/client/connect.c    | 6 +-----
>  fs/smb/client/fs_context.c | 5 +++++
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> --
> 2.34.1
>
>