From patchwork Mon Jul 26 17:05:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 114316 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o6QH5XQE028070 for ; Mon, 26 Jul 2010 17:05:33 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754608Ab0GZRFd (ORCPT ); Mon, 26 Jul 2010 13:05:33 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:47280 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754645Ab0GZRFc (ORCPT ); Mon, 26 Jul 2010 13:05:32 -0400 X-Authority-Analysis: v=1.1 cv=vJRpDULq0YkYIrbJCOZOCyAqb32M1QteodnGhKs/5qQ= c=1 sm=0 a=kNXTDkjTvKYA:10 a=ld/erqUjW76FpBUqCqkKeA==:17 a=hGzw-44bAAAA:8 a=LpIieHbmrV05-7L9eckA:9 a=m7Q-rWQUfKW_lX8_4uoA:7 a=DvBilyuQr1dH5FdM_wkAgvZPCbsA:4 a=dowx1zmaLagA:10 a=ld/erqUjW76FpBUqCqkKeA==:117 X-Cloudmark-Score: 0 X-Originating-IP: 71.70.153.3 Received: from [71.70.153.3] ([71.70.153.3:47589] helo=mail.poochiereds.net) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.2.39 r()) with ESMTP id E0/36-07882-A50CD4C4; Mon, 26 Jul 2010 17:05:31 +0000 Received: by mail.poochiereds.net (Postfix, from userid 4447) id 9D86D58127; Mon, 26 Jul 2010 13:05:30 -0400 (EDT) From: Jeff Layton To: linux-cifs@vger.kernel.org Subject: [PATCH] cifs.upcall: require a uid= or creduid= parm Date: Mon, 26 Jul 2010 13:05:28 -0400 Message-Id: <1280163930-983-1-git-send-email-jlayton@samba.org> X-Mailer: git-send-email 1.7.1.1 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 26 Jul 2010 17:05:33 +0000 (UTC) diff --git a/cifs.upcall.c b/cifs.upcall.c index 1f4341d..8f7850a 100644 --- a/cifs.upcall.c +++ b/cifs.upcall.c @@ -707,6 +707,11 @@ int main(const int argc, char *const argv[]) goto out; } ccname = find_krb5_cc(CIFS_DEFAULT_KRB5_DIR, arg.uid); + } else { + /* no uid= or creduid= parm -- something is wrong */ + syslog(LOG_ERR, "No uid= or creduid= parm specified"); + rc = 1; + goto out; } host = arg.hostname;