diff mbox

CIFS: Fix sparse error

Message ID 1307609933-5632-2-git-send-email-piastryyy@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Shilovsky June 9, 2011, 8:58 a.m. UTC
cifs_sb_master_tlink was declared as inline, but without a definition.
Remove the declaration and move the definition up.

Signed-off-by: Pavel Shilovsky <piastryyy@gmail.com>
---
 fs/cifs/connect.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

Comments

Jeff Layton June 9, 2011, 11:11 a.m. UTC | #1
On Thu,  9 Jun 2011 12:58:53 +0400
Pavel Shilovsky <piastryyy@gmail.com> wrote:

> cifs_sb_master_tlink was declared as inline, but without a definition.
> Remove the declaration and move the definition up.
> 
> Signed-off-by: Pavel Shilovsky <piastryyy@gmail.com>
> ---
>  fs/cifs/connect.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 23addcb..76a6670 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2203,7 +2203,10 @@ cifs_put_tlink(struct tcon_link *tlink)
>  }
>  
>  static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb);
> +cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> +{
> +	return cifs_sb->master_tlink;
> +}
>  
>  static int
>  compare_mount_options(struct super_block *sb, struct cifs_mnt_data *mnt_data)
> @@ -3538,12 +3541,6 @@ out:
>  	return tcon;
>  }
>  
> -static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> -{
> -	return cifs_sb->master_tlink;
> -}
> -
>  struct cifs_tcon *
>  cifs_sb_master_tcon(struct cifs_sb_info *cifs_sb)
>  {

Reviewed-by: Jeff Layton <jlayton@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve French June 9, 2011, 2:13 p.m. UTC | #2
merged

On Thu, Jun 9, 2011 at 3:58 AM, Pavel Shilovsky <piastryyy@gmail.com> wrote:
> cifs_sb_master_tlink was declared as inline, but without a definition.
> Remove the declaration and move the definition up.
>
> Signed-off-by: Pavel Shilovsky <piastryyy@gmail.com>
> ---
>  fs/cifs/connect.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 23addcb..76a6670 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2203,7 +2203,10 @@ cifs_put_tlink(struct tcon_link *tlink)
>  }
>
>  static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb);
> +cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> +{
> +       return cifs_sb->master_tlink;
> +}
>
>  static int
>  compare_mount_options(struct super_block *sb, struct cifs_mnt_data *mnt_data)
> @@ -3538,12 +3541,6 @@ out:
>        return tcon;
>  }
>
> -static inline struct tcon_link *
> -cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
> -{
> -       return cifs_sb->master_tlink;
> -}
> -
>  struct cifs_tcon *
>  cifs_sb_master_tcon(struct cifs_sb_info *cifs_sb)
>  {
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
diff mbox

Patch

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 23addcb..76a6670 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2203,7 +2203,10 @@  cifs_put_tlink(struct tcon_link *tlink)
 }
 
 static inline struct tcon_link *
-cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb);
+cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
+{
+	return cifs_sb->master_tlink;
+}
 
 static int
 compare_mount_options(struct super_block *sb, struct cifs_mnt_data *mnt_data)
@@ -3538,12 +3541,6 @@  out:
 	return tcon;
 }
 
-static inline struct tcon_link *
-cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
-{
-	return cifs_sb->master_tlink;
-}
-
 struct cifs_tcon *
 cifs_sb_master_tcon(struct cifs_sb_info *cifs_sb)
 {