From patchwork Sat Aug 20 01:18:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1081972 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7K1IVtf017607 for ; Sat, 20 Aug 2011 01:18:32 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707Ab1HTBSa (ORCPT ); Fri, 19 Aug 2011 21:18:30 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:65421 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613Ab1HTBSa (ORCPT ); Fri, 19 Aug 2011 21:18:30 -0400 Received: by ywf7 with SMTP id 7so2564318ywf.19 for ; Fri, 19 Aug 2011 18:18:29 -0700 (PDT) Received: by 10.90.234.7 with SMTP id g7mr18204agh.51.1313803109783; Fri, 19 Aug 2011 18:18:29 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-075-177-182-191.nc.res.rr.com [75.177.182.191]) by mx.google.com with ESMTPS id l38sm3099336ani.44.2011.08.19.18.18.27 (version=SSLv3 cipher=OTHER); Fri, 19 Aug 2011 18:18:28 -0700 (PDT) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org Subject: [PATCH] cifs: switch CIFSSMBQAllEAs to use memcmp Date: Fri, 19 Aug 2011 21:18:24 -0400 Message-Id: <1313803104-31810-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.6 Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 20 Aug 2011 01:18:32 +0000 (UTC) ...as that's more efficient when we know that the lengths are equal. Reported-by: David Howells Signed-off-by: Jeff Layton Reviewed-by: Suresh Jayaraman --- fs/cifs/cifssmb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index f4d0988..7bac906 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -5849,7 +5849,7 @@ QAllEAsRetry: if (ea_name) { if (ea_name_len == name_len && - strncmp(ea_name, temp_ptr, name_len) == 0) { + memcmp(ea_name, temp_ptr, name_len) == 0) { temp_ptr += name_len + 1; rc = value_len; if (buf_size == 0)