| Message ID | 1342634346-22818-2-git-send-email-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2012/7/18 Jeff Layton <jlayton@redhat.com>: > There's a comment here about how we don't want to modify this length, > but nothing in this function actually does. > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- > fs/cifs/transport.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c > index 3097ee5..fa51913 100644 > --- a/fs/cifs/transport.c > +++ b/fs/cifs/transport.c > @@ -126,7 +126,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) > int rc = 0; > int i = 0; > struct msghdr smb_msg; > - __be32 *buf_len = (__be32 *)(iov[0].iov_base); > unsigned int len = iov[0].iov_len; > unsigned int total_len; > int first_vec = 0; > @@ -235,9 +234,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) > else > rc = 0; > > - /* Don't want to modify the buffer as a side effect of this call. */ > - *buf_len = cpu_to_be32(smb_buf_length); > - > return rc; > } > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Pavel Shilovsky <pshilovsky@samba.org
2012/7/25 Pavel Shilovsky <piastryyy@gmail.com>: > 2012/7/18 Jeff Layton <jlayton@redhat.com>: >> There's a comment here about how we don't want to modify this length, >> but nothing in this function actually does. >> >> Signed-off-by: Jeff Layton <jlayton@redhat.com> >> --- >> fs/cifs/transport.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c >> index 3097ee5..fa51913 100644 >> --- a/fs/cifs/transport.c >> +++ b/fs/cifs/transport.c >> @@ -126,7 +126,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) >> int rc = 0; >> int i = 0; >> struct msghdr smb_msg; >> - __be32 *buf_len = (__be32 *)(iov[0].iov_base); >> unsigned int len = iov[0].iov_len; >> unsigned int total_len; >> int first_vec = 0; >> @@ -235,9 +234,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) >> else >> rc = 0; >> >> - /* Don't want to modify the buffer as a side effect of this call. */ >> - *buf_len = cpu_to_be32(smb_buf_length); >> - >> return rc; >> } >> >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Reviewed-by: Pavel Shilovsky <pshilovsky@samba.org (sorry for the typo) Reviewed-by: Pavel Shilovsky <pshilovsky@samba.org>
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 3097ee5..fa51913 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -126,7 +126,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) int rc = 0; int i = 0; struct msghdr smb_msg; - __be32 *buf_len = (__be32 *)(iov[0].iov_base); unsigned int len = iov[0].iov_len; unsigned int total_len; int first_vec = 0; @@ -235,9 +234,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec) else rc = 0; - /* Don't want to modify the buffer as a side effect of this call. */ - *buf_len = cpu_to_be32(smb_buf_length); - return rc; }
There's a comment here about how we don't want to modify this length, but nothing in this function actually does. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/cifs/transport.c | 4 ---- 1 file changed, 4 deletions(-)