From patchwork Fri Jul 20 15:48:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1221541 Return-Path: X-Original-To: patchwork-cifs-client@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 41BD1E0038 for ; Fri, 20 Jul 2012 15:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753263Ab2GTPs4 (ORCPT ); Fri, 20 Jul 2012 11:48:56 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:39280 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753161Ab2GTPs4 (ORCPT ); Fri, 20 Jul 2012 11:48:56 -0400 Received: by yenl2 with SMTP id l2so4112870yen.19 for ; Fri, 20 Jul 2012 08:48:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=oygDjdTCo+kXa9dk2u1b6iNgaI6E7dFf51ojrpKDL+E=; b=ENpDCWyw5qLsvopvMQmqG6Zs/D7Y3M5sJo5V0cjy6YFNngpGGc+XwYcNN5w0RH2Iqo pjYs+8HOBEELUi+f1gKglIfCN5scFvmXRDLzldQ/rwEnYjmCVGgI8JYpAf42V0DFrkaP rVKAmHori6RUeAXhb08ThwE0Er19YeOEpEa82eBSvM3HK9VLPh44QgEepWv8/L0HgCO0 fvjQXf5ohZFchShZO84O6cgzDbNUYfyW7uhNHCHtfwwF4ndKFO9N6CV1kslOpG04bpvt gPRCD6HAvwpjhbP7JXZsvzVzNe3padjzSKBchIWHlzGnczyleif0KI4ZIIxHZQaxsFuq QQ1A== Received: by 10.236.124.13 with SMTP id w13mr5854408yhh.76.1342799335751; Fri, 20 Jul 2012 08:48:55 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-076-182-054-194.nc.res.rr.com. [76.182.54.194]) by mx.google.com with ESMTPS id x8sm10065294yhd.18.2012.07.20.08.48.54 (version=SSLv3 cipher=OTHER); Fri, 20 Jul 2012 08:48:55 -0700 (PDT) From: Jeff Layton To: smfrench@gmail.com Cc: linux-cifs@vger.kernel.org Subject: [PATCH] cifs: ensure that cifs_readpages calls cifsFileInfo_get under the cifs_file_list_lock Date: Fri, 20 Jul 2012 11:48:50 -0400 Message-Id: <1342799330-2919-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQnaJSek21F7vlMqPoHxMi0cftI44ZInkQkySl8nqQYsv15MWlHRnkT5JtdQ7xLlDRGavpXJ Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org ...regression introduced in 6993f74a5. Signed-off-by: Jeff Layton --- fs/cifs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 513adbc..45508cf 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -3083,8 +3083,8 @@ static int cifs_readpages(struct file *file, struct address_space *mapping, } spin_lock(&cifs_file_list_lock); - spin_unlock(&cifs_file_list_lock); rdata->cfile = cifsFileInfo_get(open_file); + spin_unlock(&cifs_file_list_lock); rdata->mapping = mapping; rdata->offset = offset; rdata->bytes = bytes;