| Message ID | 1463623053-117056-1-git-send-email-smfrench@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2016-05-18 at 20:57 -0500, Steve French wrote: > Remove some obsolete comments in the cifs inode_operations > structs that were pointed out by Stephen Rothwell. > > CC: Stephen Rothwell <sfr@canb.auug.org.au> > CC: Al Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Steve French <steve.french@primarydata.com> Acked-By: Sachin Prabhu <sprabhu@redhat.com> > --- > fs/cifs/cifsfs.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index 67f622d..5d8b7ed 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -890,7 +890,6 @@ const struct inode_operations cifs_dir_inode_ops > = { > .rmdir = cifs_rmdir, > .rename2 = cifs_rename2, > .permission = cifs_permission, > -/* revalidate:cifs_revalidate, */ > .setattr = cifs_setattr, > .symlink = cifs_symlink, > .mknod = cifs_mknod, > @@ -901,9 +900,8 @@ const struct inode_operations cifs_dir_inode_ops > = { > }; > > const struct inode_operations cifs_file_inode_ops = { > -/* revalidate:cifs_revalidate, */ > .setattr = cifs_setattr, > - .getattr = cifs_getattr, /* do we need this anymore? */ > + .getattr = cifs_getattr, > .permission = cifs_permission, > .setxattr = generic_setxattr, > .getxattr = generic_getxattr, > @@ -915,9 +913,6 @@ const struct inode_operations > cifs_symlink_inode_ops = { > .readlink = generic_readlink, > .get_link = cifs_get_link, > .permission = cifs_permission, > - /* BB add the following two eventually */ > - /* revalidate: cifs_revalidate, > - setattr: cifs_notify_change, *//* BB do we need notify > change */ > .setxattr = generic_setxattr, > .getxattr = generic_getxattr, > .listxattr = cifs_listxattr, -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 67f622d..5d8b7ed 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -890,7 +890,6 @@ const struct inode_operations cifs_dir_inode_ops = { .rmdir = cifs_rmdir, .rename2 = cifs_rename2, .permission = cifs_permission, -/* revalidate:cifs_revalidate, */ .setattr = cifs_setattr, .symlink = cifs_symlink, .mknod = cifs_mknod, @@ -901,9 +900,8 @@ const struct inode_operations cifs_dir_inode_ops = { }; const struct inode_operations cifs_file_inode_ops = { -/* revalidate:cifs_revalidate, */ .setattr = cifs_setattr, - .getattr = cifs_getattr, /* do we need this anymore? */ + .getattr = cifs_getattr, .permission = cifs_permission, .setxattr = generic_setxattr, .getxattr = generic_getxattr, @@ -915,9 +913,6 @@ const struct inode_operations cifs_symlink_inode_ops = { .readlink = generic_readlink, .get_link = cifs_get_link, .permission = cifs_permission, - /* BB add the following two eventually */ - /* revalidate: cifs_revalidate, - setattr: cifs_notify_change, *//* BB do we need notify change */ .setxattr = generic_setxattr, .getxattr = generic_getxattr, .listxattr = cifs_listxattr,
Remove some obsolete comments in the cifs inode_operations structs that were pointed out by Stephen Rothwell. CC: Stephen Rothwell <sfr@canb.auug.org.au> CC: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Steve French <steve.french@primarydata.com> --- fs/cifs/cifsfs.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)