From patchwork Wed Jun 28 18:56:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 9815067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C16C0603F2 for ; Wed, 28 Jun 2017 18:57:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9C481FFAD for ; Wed, 28 Jun 2017 18:57:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AD9FA2861C; Wed, 28 Jun 2017 18:57:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5917A1FFAD for ; Wed, 28 Jun 2017 18:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbdF1S5d (ORCPT ); Wed, 28 Jun 2017 14:57:33 -0400 Received: from a2nlsmtp01-03.prod.iad2.secureserver.net ([198.71.225.37]:47088 "EHLO a2nlsmtp01-03.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbdF1S5S (ORCPT ); Wed, 28 Jun 2017 14:57:18 -0400 Received: from linuxonhyperv.com ([107.180.71.197]) by : HOSTING RELAY : with SMTP id QI8DdcJoc683VQI8DdTPO5; Wed, 28 Jun 2017 11:56:05 -0700 x-originating-ip: 107.180.71.197 Received: from longli by linuxonhyperv.com with local (Exim 4.89) (envelope-from ) id 1dQI8D-0008GU-PG; Wed, 28 Jun 2017 11:56:05 -0700 From: Long Li To: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [PATCH v2] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Date: Wed, 28 Jun 2017 11:56:03 -0700 Message-Id: <1498676163-31746-1-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.1 X-CMAE-Envelope: MS4wfDepx/R1xFELrWH7A/9GpS2Rf31ERpcJywT2foTymAZOmXDPQiZT46ajdQ1i+vMhSpVz/jalI7h4ppkc0rR+PNb2O//u8XvrHj1Kia7wO7RRLOV8VnMv exBEqm4g9JCGVNmhjDPz3/PLj0+l91eL5GOaZ9HdMJR91z26DYZaCvO/FrZ9dXdMr4lPy+qlpdt4RqlV9ZwXSA9BLzByE1xMKVLXQbhv8en3UTJg8xG5Koyy zbwkkwngaxRMqUXjfMbeQTFTRrBMcFLDMHCOzRWr2g9yLn4rl2OS+rOOnQ5bx/VzFfNsiwBITEILs0hV44A6xY3JIyTA5qaikCb8jkrVGUI= Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Long Li In cifs_call_async, server may respond as soon as I/O is submitted. Because mid entry is freed on the return path, it should not be modified after I/O is submitted. cifs_save_when_sent modifies the sent timestamp in mid entry, and should not be called after I/O. Call it before I/O. Signed-off-by: Long Li --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 47a125e..ba62aaf 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst, spin_unlock(&GlobalMid_Lock); + cifs_save_when_sent(mid); cifs_in_send_inc(server); rc = smb_send_rqst(server, rqst, flags); cifs_in_send_dec(server); - cifs_save_when_sent(mid); if (rc < 0) { server->sequence_number -= 2;