From patchwork Sun Mar 6 13:26:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 613441 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p26DQqJe004764 for ; Sun, 6 Mar 2011 13:26:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834Ab1CFN0u (ORCPT ); Sun, 6 Mar 2011 08:26:50 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:47592 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738Ab1CFN0t (ORCPT ); Sun, 6 Mar 2011 08:26:49 -0500 Received: by iyb26 with SMTP id 26so3204464iyb.19 for ; Sun, 06 Mar 2011 05:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=9TOyamz+OT9cIcM2yHSUOvLFLnV56Fqg2EwqmfNlci8=; b=ciLGpk7Z8dkBbNdl0KLW0HUPbLlg6kGVZhc2OZHJBh/G8XGTWlvNprzmGVyrEtCOJw 2I97c7eyKO3uTmAz/0OSc1N+QRoudKg4blu1ZJ2r8jdxKWioRrATe0PmosBNV2dF5sSE 6hUQvu7hNtqLnYi5jgKvXEkZ8PjBqQLLRHYHw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=T7skc6jaq8LjLU+CIBlHQQ2RlXnm5nN3zDCy8zcOwWxXacoqpDEgCzeiYfn4MnDI5+ KUWZOg5sa7STinYVKG9bJNUtMhnKjqfVWKN6Nzq3gdP/a3jn/dE46+36F5xaJGZFyq6G +9ZTtzczTMOh3GkjDcGN/GrpO1XJtCeLLxBdA= Received: by 10.231.142.23 with SMTP id o23mr2175789ibu.57.1299418008508; Sun, 06 Mar 2011 05:26:48 -0800 (PST) Received: from bicker ([212.49.88.34]) by mx.google.com with ESMTPS id z4sm1726276ibg.13.2011.03.06.05.26.33 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Mar 2011 05:26:45 -0800 (PST) Date: Sun, 6 Mar 2011 16:26:21 +0300 From: Dan Carpenter To: Steve French Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, kernel-janitors@vger.kernel.org Subject: [patch] cifs: writing past the end of the array Message-ID: <20110306132621.GN3416@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 06 Mar 2011 13:26:52 +0000 (UTC) diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c index 3967635..1525d5e 100644 --- a/fs/cifs/smbencrypt.c +++ b/fs/cifs/smbencrypt.c @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24) int rc; unsigned char p16[16], p21[21]; - memset(p16, '\0', 21); + memset(p16, '\0', 16); memset(p21, '\0', 21); rc = E_md4hash(passwd, p16);