diff mbox

cifs: remove redundant return in cifs_creation_time_get

Message ID 20170606233345.5980-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King June 6, 2017, 11:33 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

There is a redundant return in function cifs_creation_time_get
that appears to be old vestigial code than can be removed. So
remove it.

Detected by CoverityScan, CID#1361924 ("Structurally dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/cifs/xattr.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Aurélien Aptel June 7, 2017, 1 p.m. UTC | #1 
Looks good to me.
Steve French June 21, 2017, 4:59 p.m. UTC | #2 
merged into cifs-2.6.git for-next

On Wed, Jun 7, 2017 at 8:00 AM, Aurélien Aptel <aaptel@suse.com> wrote:
>
> Looks good to me.
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
index 3cb5c9e2d4e7..de50e749ff05 100644
--- a/fs/cifs/xattr.c
+++ b/fs/cifs/xattr.c
@@ -188,8 +188,6 @@  static int cifs_creation_time_get(struct dentry *dentry, struct inode *inode,
 	pcreatetime = (__u64 *)value;
 	*pcreatetime = CIFS_I(inode)->createtime;
 	return sizeof(__u64);
-
-	return rc;
 }