diff mbox series

[-next] cifsd: fix build error without CONFIG_OID_REGISTRY

Message ID 20210520134211.1667806-1-weiyongjun1@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] cifsd: fix build error without CONFIG_OID_REGISTRY | expand

Commit Message

weiyongjun (A) May 20, 2021, 1:42 p.m. UTC
Fix build error when CONFIG_OID_REGISTRY is not set:

mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
asn1.c:(.text+0xbec): undefined reference to `sprint_oid'

Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 fs/cifsd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Namjae Jeon May 21, 2021, 12:56 a.m. UTC | #1
> Fix build error when CONFIG_OID_REGISTRY is not set:
> 
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
> asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
> asn1.c:(.text+0xbec): undefined reference to `sprint_oid'
> 
> Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I will apply it. Thanks for your patch!

Hyunchul, You also need to add this change to your cifs patch.

> ---
>  fs/cifsd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index 5316b1035fbe..e6448b04f46e 100644
> --- a/fs/cifsd/Kconfig
> +++ b/fs/cifsd/Kconfig
> @@ -18,6 +18,7 @@ config SMB_SERVER
>  	select CRYPTO_CCM
>  	select CRYPTO_GCM
>  	select ASN1
> +	select OID_REGISTRY
>  	default n
>  	help
>  	  Choose Y here if you want to allow SMB3 compliant clients
Hyunchul Lee May 21, 2021, 1:28 a.m. UTC | #2
2021년 5월 21일 (금) 오전 9:56, Namjae Jeon <namjae.jeon@samsung.com>님이 작성:
>
> > Fix build error when CONFIG_OID_REGISTRY is not set:
> >
> > mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
> > asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
> > mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
> > asn1.c:(.text+0xbec): undefined reference to `sprint_oid'
> >
> > Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> I will apply it. Thanks for your patch!
>
> Hyunchul, You also need to add this change to your cifs patch.
>

Okay, I will apply this.

Thanks,
Hyunchul

> > ---
> >  fs/cifsd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index 5316b1035fbe..e6448b04f46e 100644
> > --- a/fs/cifsd/Kconfig
> > +++ b/fs/cifsd/Kconfig
> > @@ -18,6 +18,7 @@ config SMB_SERVER
> >       select CRYPTO_CCM
> >       select CRYPTO_GCM
> >       select ASN1
> > +     select OID_REGISTRY
> >       default n
> >       help
> >         Choose Y here if you want to allow SMB3 compliant clients
>
>
diff mbox series

Patch

diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig
index 5316b1035fbe..e6448b04f46e 100644
--- a/fs/cifsd/Kconfig
+++ b/fs/cifsd/Kconfig
@@ -18,6 +18,7 @@  config SMB_SERVER
 	select CRYPTO_CCM
 	select CRYPTO_GCM
 	select ASN1
+	select OID_REGISTRY
 	default n
 	help
 	  Choose Y here if you want to allow SMB3 compliant clients